clean up routine task references upon task deletion#1676
Open
Abhishek2005-ard wants to merge 1 commit into
Open
clean up routine task references upon task deletion#1676Abhishek2005-ard wants to merge 1 commit into
Abhishek2005-ard wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When a task is deleted via the single task deletion endpoint (
deleteTaskcontroller), the backend removes the task from the database but fails to clean up corresponding references in theRoutinemodel. This leaves orphanedtaskIdreferences inside user routines, leading to database integrity issues and potential API errors when retrieving or modifying routines.This PR resolves the issue by executing a
$pulloperation on theRoutinecollection inside thedeleteTaskhandler to clear references to the deleted task, matching the cleanup logic already used in thebulkDeleteTaskshandler.Changes Made
deleteTaskinbackend/controllers/taskController.jsto runRoutine.updateManywith a$pullaction targeting the deletedtaskId.Verification & Testing
npm run lint(Passed)npm run test(Passed)