prevent mass assignment and IDOR in task and routine updates#1663
Open
Abhishek2005-ard wants to merge 3 commits into
Open
prevent mass assignment and IDOR in task and routine updates#1663Abhishek2005-ard wants to merge 3 commits into
Abhishek2005-ard wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses security vulnerabilities (Mass Assignment and IDOR) within the Task and Routine update/creation controllers:
userIdand_id) from request payloads prior to updating Tasks and Routines.Changes
taskController.js):updateTaskto only permit defined, non-sensitive keys (title,description,tags,priority,status,dueDate,actualDuration).routineController.js):updateRoutineto only permitname,description, anditems.createRoutineandupdateRoutineto validate that all referenced task IDs initemsare owned by the current user.Taskmodel to support validation.Testing & Verification
userId,_id,createdAt) are stripped of those keys.400 Bad Requesterror.npm run lint.close #1651