enforce password policy complexity on profile update#1662
Open
Abhishek2005-ard wants to merge 3 commits into
Open
enforce password policy complexity on profile update#1662Abhishek2005-ard wants to merge 3 commits into
Abhishek2005-ard wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses a password policy bypass vulnerability in the profile update (
updateProfile) endpoint. Previously, password complexity constraints (minimum 8 characters, at least one uppercase letter, one digit, and one special character) were only validated during signup. Users could update their password to weak passwords via the profile settings, bypassing these requirements.Changes
updateProfilefunction inbackend/controllers/authController.js.currentPasswordandnewPasswordwhen a password change is requested.newPasswordagainst the application's standard password complexity regular expression:/^(?=.*[A-Z])(?=.*\d)(?=.*[^A-Za-z0-9]).{8,}$/.400response code with a descriptive validation error message upon check failures.Testing & Verification
400error.400error.npm run lint) to ensure styling is consistent.close#1650