Add ability to add and remove shapes from drawing manager data source#110
Merged
arnaudleclerc merged 3 commits intoarnaudleclerc:developfrom Oct 21, 2025
Merged
Conversation
…s from drawing manager datasource
Owner
arnaudleclerc
left a comment
arnaudleclerc
left a comment
There was a problem hiding this comment.
@mtech-rherpio Sorry, I apparently totally missed your pull request.
This looks like a nice addition and the code looks fine. However, I am missing some unit tests on the new DrawingManager. Would it be possible to add some ?
Contributor
Author
|
Sure, I'll try to add tests when I have some time |
Contributor
Author
|
@arnaudleclerc I added some tests for the drawing manager, was that enough or should I add more? |
arnaudleclerc
approved these changes
Oct 21, 2025
Owner
|
@mtech-rherpio Thanks a lot. Everything looks fine! A new version should be generated soon. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added DrawingManager component that can be used to add and remove shapes from drawing manager data source.
Added sample page for trying out the functionality.
Solves #109 and #73