Drop legacy submit_message & groups columns from jobs#4932
Draft
tgucks wants to merge 1 commit into
Draft
Conversation
Signed-off-by: Trey Guckian <24757349+tgucks@users.noreply.github.com>
submit_message & groups columns from jobs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Data migration / cleanup
What this PR does / why we need it
Final step of the
submit_message/groupsmigration from thejobstable to the dedicatedjob_metadatatable (see the prior PRs here: first, second, and third).This PR:
040_drop_jobs_legacy_metadata_columns.sql, which dropssubmit_messageandgroupsfrom thejobstable. From this PR forward,submit_messageandgroupslive exclusively injob_metadata.JobMetadataMigrationPhaseconfig field from both the scheduler and scheduleringester, along with thelegacy/dualWrite/cutoverswitching logic that read it.job_metadata_migration.go) and the phase-specific tests.Special notes for your reviewer
JobMetadataMigrationPhaseneeds to be set tocutoverprior to dropping the columns. Once pt-3 is rolled out, this PR is safe.JobMetadataMigrationPhasein scheduler & scheduleringester so they must be removed from any custom configs.