Skip to content

Drop legacy submit_message & groups columns from jobs#4932

Draft
tgucks wants to merge 1 commit into
split-job-spec-table-pt-3from
split-job-spec-table-pt-4
Draft

Drop legacy submit_message & groups columns from jobs#4932
tgucks wants to merge 1 commit into
split-job-spec-table-pt-3from
split-job-spec-table-pt-4

Conversation

@tgucks

@tgucks tgucks commented May 21, 2026

Copy link
Copy Markdown
Collaborator

What type of PR is this?

Data migration / cleanup

What this PR does / why we need it

Final step of the submit_message / groups migration from the jobs table to the dedicated job_metadata table (see the prior PRs here: first, second, and third).

This PR:

  • Adds migration 040_drop_jobs_legacy_metadata_columns.sql, which drops submit_message and groups from the jobs table. From this PR forward, submit_message and groups live exclusively in job_metadata.
  • Removes the JobMetadataMigrationPhase config field from both the scheduler and scheduleringester, along with the legacy / dualWrite / cutover switching logic that read it.
  • Deletes the now-dead migration helpers (job_metadata_migration.go) and the phase-specific tests.

Special notes for your reviewer

  • Do not merge until the prior PRs (second, and third) are merged. JobMetadataMigrationPhase needs to be set to cutover prior to dropping the columns. Once pt-3 is rolled out, this PR is safe.
  • This PR removes the config flags JobMetadataMigrationPhase in scheduler & scheduleringester so they must be removed from any custom configs.

Signed-off-by: Trey Guckian <24757349+tgucks@users.noreply.github.com>
@tgucks tgucks changed the title Drop legacy submit_message & groups columns from jobs Drop legacy submit_message & groups columns from jobs May 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant