Add missing norm.weight parameters to cohere.json#674
Merged
Conversation
|
All contributors have signed the CLA ✍️ ✅ |
Contributor
Author
|
I have read the CLA Document and I hereby sign the CLA |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the missing the
self_attn.q_norm.weightandself_attn.k_norm.weightparameters, see:https://huggingface.co/CohereLabs/c4ai-command-r-plus/blob/main/model.safetensors.index.json
{ "weight_map": { "model.embed_tokens.weight": "model-00001-of-00044.safetensors", "model.layers.0.input_layernorm.weight": "model-00002-of-00044.safetensors", "model.layers.0.mlp.down_proj.weight": "model-00002-of-00044.safetensors", "model.layers.0.mlp.gate_proj.weight": "model-00002-of-00044.safetensors", "model.layers.0.mlp.up_proj.weight": "model-00002-of-00044.safetensors", "model.layers.0.self_attn.k_norm.weight": "model-00002-of-00044.safetensors", "model.layers.0.self_attn.k_proj.weight": "model-00002-of-00044.safetensors", "model.layers.0.self_attn.o_proj.weight": "model-00002-of-00044.safetensors", "model.layers.0.self_attn.q_norm.weight": "model-00002-of-00044.safetensors", "model.layers.0.self_attn.q_proj.weight": "model-00002-of-00044.safetensors", "model.layers.0.self_attn.v_proj.weight": "model-00002-of-00044.safetensors", "...", }Note
Low Risk
Single architecture JSON metadata change with no runtime logic; only affects which Cohere tensors mergekit recognizes during merges.
Overview
Updates the Cohere mergekit architecture template so per-layer weight lists match real checkpoints (e.g. Command R+).
Adds
model.layers.${layer_index}.self_attn.q_norm.weightandmodel.layers.${layer_index}.self_attn.k_norm.weighttolayer_templates, placed with the other self-attention tensors so merges no longer omit these norms.Reviewed by Cursor Bugbot for commit bb241b6. Bugbot is set up for automated code reviews on this repo. Configure here.