Repository navigation
fix: make apt-get update non-fatal in manage_deps - #121
Merged
Merged
Conversation
On GitHub Actions runners the package lists are pre-populated by the runner image; a redundant apt-get update can fail with exit 100 if any third-party apt repo has a transient issue. Adding '|| true' keeps the install step working with the existing cache while still running update for fresh developer environments where it can succeed. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
alinush
self-requested a review
April 29, 2026 18:32
alinush
approved these changes
Apr 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
apt-get updatewas called before every apt package install inmanage_deps.pyapt-get install, leavingnlohmann-json3-devuninstalledfatal error: nlohmann/json.hpp: No such file or directoryThe fix adds
|| trueto make the update step non-fatal. The runner image's package lists are already populated so the install succeeds even without a fresh update; on fresh developer machinesapt-get updateusually succeeds anyway.Test plan
🤖 Generated with Claude Code