Refs #984: sendpacket: avoid endless retries on ENOBUFS/EAGAIN#986
Open
d3156 wants to merge 1 commit intoappneta:masterfrom
Open
Refs #984: sendpacket: avoid endless retries on ENOBUFS/EAGAIN#986d3156 wants to merge 1 commit intoappneta:masterfrom
d3156 wants to merge 1 commit intoappneta:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #984.
Problem
When using the PF_PACKET injection method,
sendpacket()may enter an endless retry loop ifsend()keeps returningENOBUFSorEAGAINcontinuously (e.g., with very large frames or under sustained buffer pressure). This results in 100% CPU usage and tcpreplay never progresses to the next packet.Change
Introduce a bounded retry loop for transient
ENOBUFS/EAGAINfailures:max_retry_countattempts and return an error so tcpreplay can continue with the next packet.How to test
ENOBUFS/EAGAINon PF_PACKET.Values are currently hard-coded and can be made configurable if maintainers prefer.