BUG-974 handle overflow in packet sending for speed_packetrate and speed_mbpsrate#982
Open
plangarb wants to merge 1 commit intoappneta:masterfrom
Open
BUG-974 handle overflow in packet sending for speed_packetrate and speed_mbpsrate#982plangarb wants to merge 1 commit intoappneta:masterfrom
plangarb wants to merge 1 commit intoappneta:masterfrom
Conversation
…eed_mbpsrate modes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Standards checklist:
sudo make testChanges:
Other comments:
Test result: ~8GB pcap file, tcpreplay command using speed_mbpsrate = 10. Speed rate is constant throughout the entire operation.
tcpreplay -i veth0 -M 10 --stats=1 8GB_test_file.pcap
Logs
Actual: 1634674 packets (8578746889 bytes) sent in 6862.99 seconds
Rated: 1250000.0 Bps, 10.00 Mbps, 238.18 pps
Actual: 1634916 packets (8579997033 bytes) sent in 6863.99 seconds
Rated: 1250000.1 Bps, 10.00 Mbps, 238.18 pps
Actual: 1635160 packets (8581249984 bytes) sent in 6865.00 seconds
Rated: 1249999.9 Bps, 9.99 Mbps, 238.18 pps
Actual: 1635403 packets (8582503398 bytes) sent in 6866.00 seconds
Rated: 1250000.1 Bps, 10.00 Mbps, 238.18 pps
Actual: 1635646 packets (8583758340 bytes) sent in 6867.00 seconds
Rated: 1250000.1 Bps, 10.00 Mbps, 238.18 pps
Actual: 1635883 packets (8585008943 bytes) sent in 6868.00 seconds
Rated: 1250000.0 Bps, 10.00 Mbps, 238.18 pps
Actual: 1636123 packets (8586262031 bytes) sent in 6869.00 seconds
Rated: 1250000.1 Bps, 10.00 Mbps, 238.18 pps
Actual: 1636353 packets (8587513641 bytes) sent in 6870.01 seconds
Rated: 1249999.9 Bps, 9.99 Mbps, 238.18 pps
Actual: 1636592 packets (8588765064 bytes) sent in 6871.01 seconds
Rated: 1250000.0 Bps, 10.00 Mbps, 238.18 pps
Test complete: 1970-01-01 02:02:32.532258497
Actual: 1636812 packets (8589935953 bytes) sent in 6871.94 seconds
Rated: 1249999.9 Bps, 9.99 Mbps, 238.18 pps
Flows: 1 flows, 0.00 fps, 1636812 unique flow packets, 0 unique non-flow packets
Statistics for network device: veth0
Successful packets: 1636812
Failed packets: 0
Truncated packets: 0
Retried packets (ENOBUFS): 0