Sleep based on fixed point in time to avoid time drift when replaying packets#915
Open
Sup3rGeo wants to merge 1 commit intoappneta:masterfrom
Open
Sleep based on fixed point in time to avoid time drift when replaying packets#915Sup3rGeo wants to merge 1 commit intoappneta:masterfrom
Sup3rGeo wants to merge 1 commit intoappneta:masterfrom
Conversation
Member
|
I haven't seen this issue before. Thanks for pointing it out. This PR appears to introduce a timestamp for every packet, which will have an incredible impact on performance. I'll shelve for now, and will see if it is possible to have a large magnifier without introducing this issue. |
|
@Sup3rGeo Thank you. Also thank you to the team for this tool, it works very well. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #724
This is missing the respective changes in send_dual_packets and probably a test. Maybe @fklassen could fill in the last pieces?
Create packets (1 second apart):
Command:
Without fixes (5.26 seconds):
With fixes (5.00 seconds):