Repository navigation
Prevent a stale coordinator DNS entry to block the database creation - #14328
Merged
johscheuer merged 3 commits intoOct 21, 2026
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
ploxiln
approved these changes
Oct 20, 2026
…ble for coordinator changes
Contributor
Result of foundationdb-pr-clang-ide on Linux RHEL 9
|
Contributor
Result of foundationdb-pr-macos-m1 on macOS 14.x
|
This comment has been minimized.
This comment has been minimized.
Contributor
Result of foundationdb-pr-macos on macOS 14.x
|
Contributor
Result of foundationdb-pr-clang-arm on Linux RHEL 9
|
This comment has been minimized.
This comment has been minimized.
saintstack
approved these changes
Oct 20, 2026
Contributor
Result of foundationdb-pr-cluster-tests on Linux RHEL 9
|
Contributor
Result of foundationdb-pr-clang on Linux RHEL 9
|
Contributor
Result of foundationdb-pr on Linux RHEL 9
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In some cases it can happen that the connection string contains an old coordinator address if using DNS entries in the cluster file those entries are resolved. If the old coordinator address is not resolvable anymore, e.g. because the Pod was deleted, this can cause the whole database creation to be stuck, even thought it fetches the updated connection string (and the file on disk was updated). This makes the whole database context unusable and the only way out of this is to update the seed connection string and restart the process. We observed that behaviour in one of our operator e2e tests. I created a new simulation test for this which failed without the fix:
$ ./packages/bin/fdbserver -r simulation -f ../src/foundationdb/tests/fast/StaleCoordinatorProtocolMonitor.toml -b off ... Run test:StaleCoordinatorProtocolMonitor Done. 0 tests passed; 1 tests failed. Unseed: 67039 Elapsed: 1095.412801 simsec, 49.243298 real seconds 1 SevError events loggedThe failure was:
and with the fix the test passed as expected (I tested with
-b offand-b on:$ ./packages/bin/fdbserver -r simulation -f ../src/foundationdb/tests/fast/StaleCoordinatorProtocolMonitor.toml -b off ... Run test:StaleCoordinatorProtocolMonitor Done. 1 tests passed; 0 tests failed. Unseed: 72090 Elapsed: 43.530260 simsec, 1.692274 real secondsI'm currently running a simulation run with Joshua and will report back once the result is available. Result: