Repository navigation
[release-8.0] Retry EINTR from KAIO truncate syscalls - #14326
Merged
Merged
Conversation
* Retry fallocate() when it fails with EINTR. * Retry the fallback ftruncate() path when it fails with EINTR. * Preserve existing EOPNOTSUPP fallback and permanent-error handling. * Add a deterministic regression test using one-shot EINTR syscall hooks. * Bound KAIO truncate EINTR retries and isolate regression tests
Collaborator
Author
|
100k joshua test: {
"id": "20261020-024757-pierce-8cc81f52825c226f",
"duration": 3752267,
"ended": 101000,
"fail": 1,
"pass": 100999,
"started": 101000,
"compressed": true,
"data_size": 40930129,
"fail_fast": 10,
"max_runs": 101000,
"priority": 100,
"runtime": "0:53:49",
"sanity": false,
"stopped": "20261020-034146",
"submitted": "20261020-024757",
"timeout": 5400,
"username": "pierce",
"remaining": "0"
}One failure seemingly unrelated:
That addr2line backtrace is a bit hard for me to decipher, it's a bunch of promise resolution functions inlined in coroutine .resume methods ... but it's this assertion: |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
saintstack
approved these changes
Oct 21, 2026
Contributor
Result of foundationdb-pr-macos-m1 on macOS 14.x
|
Contributor
Result of foundationdb-pr-clang on Linux RHEL 9
|
Contributor
Result of foundationdb-pr on Linux RHEL 9
|
Contributor
Result of foundationdb-pr-clang-arm on Linux RHEL 9
|
Contributor
Result of foundationdb-pr-cluster-tests on Linux RHEL 9
|
Contributor
Result of foundationdb-pr-macos on macOS 14.x
|
spraza
approved these changes
Oct 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
backport of #14081