Skip to content

[MEDIUM] Prevent code injection in inheritable_attr #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
OskarEichler wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[MEDIUM] Prevent code injection in inheritable_attr #28

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 14 additions & 10 deletions lib/uber/inheritable_attr.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,16 +2,20 @@ module Uber
module InheritableAttr

def inheritable_attr(name, options={})
instance_eval <<-RUBY, __FILE__, __LINE__ + 1
def #{name}=(v)
@#{name} = v
end

def #{name}
return @#{name} if instance_variable_defined?(:@#{name})
@#{name} = InheritableAttribute.inherit_for(self, :#{name}, #{options})
end
RUBY
name = name.to_s
variable = "@#{name}"
instance_variable_defined?(variable) # validate the name
method = name.to_sym
options = options.dup

define_singleton_method(:"#{name}=") do |value|
instance_variable_set(variable, value)
end

define_singleton_method(method) do
return instance_variable_get(variable) if instance_variable_defined?(variable)
instance_variable_set(variable, InheritableAttribute.inherit_for(self, method, options))
end
end

def self.inherit_for(klass, name, options={})
Expand Down