fix(ci): generate vendor tree before lint - #207
Merged
Conversation
The Tests workflow suppresses package lifecycle scripts during dependency installation, so lint reaches its configured vendor-mode package loader without the repository's ignored vendor tree. Package loading then fails before golangci-lint can analyze source. Run the existing vendor script explicitly before caching tools or executing Go commands. Complete the checksums needed by the Aptre bootstrap and resolve the YAML findings that the loader failure previously masked. Keep the YAML parser and emitter behavior stable while checking each narrow integer conversion. Remove only unreachable private libyaml remnants and behavior-preserving lint findings. Directive coverage pins supported version and escaped tag URI behavior, including malformed input errors. The generated vendor tree remains ignored and untracked. Existing module versions, public YAML APIs, and serialized YAML and JSON representations do not change. Signed-off-by: Christian Stewart <christian@aperture.us>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Tests workflow installs dependencies with lifecycle scripts disabled, so lint reaches its configured vendor-mode loader without the repository's ignored vendor tree and fails before analyzing source.
This change runs the existing vendor script explicitly before Go commands, completes the checksums needed by the tool bootstrap, and resolves the YAML findings that the loader failure masked. The YAML cleanup checks narrow integer conversions, removes unreachable private remnants, and adds directive coverage for supported and malformed input.
The generated vendor tree remains ignored and untracked. Existing module versions and public YAML APIs do not change.