fix(lostresource): keep witness locations in suppressible diagnostics - #62
Merged
Merged
Conversation
Signed-off-by: Christian Stewart <christian@aperture.us>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Keep each missing-release witness in the acquisition diagnostic. golangci-lint v2.1.6 expands related information into independent findings, leaving orphan warnings when an intentional acquisition is suppressed with nolint. The single diagnostic retains the witness line and lets suppression apply to the entire finding.
Analyzer fixtures and source lint pass. The change follows a full consumer audit that exposed the orphan warnings on terminal-lifecycle tests.