fix(aptre): remove custom golangci-lint stamp on tool invalidation - #55
Merged
Conversation
Tool invalidation deleted bin/golangci-lint but kept the custom-build stamp beside it. The next ensureTool run rebuilt the stock binary while maybeBuildCustomGolangCILint saw a matching stamp and skipped the custom plugin build, so every golangci-lint invocation failed to resolve configured plugin linters until .tools/bin was removed by hand. Name the stamp path once and remove it together with the tool binaries during invalidation, so a rebuilt binary either matches the stamp or gets a fresh custom build. Signed-off-by: Christian Stewart <christian@aperture.us>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tool invalidation deleted bin/golangci-lint but kept the custom-build stamp beside it. The next ensureTool run rebuilt the stock binary, and maybeBuildCustomGolangCILint saw a matching stamp and skipped the custom plugin build. Every later golangci-lint invocation then failed to resolve the configured plugin linters until .tools/bin was removed by hand.
This names the stamp path once and removes it together with the tool binaries during invalidation, so a rebuilt binary either matches the stamp or gets a fresh custom build.
TestInvalidateToolBinariesRemovesCustomGolangCIStamp fails against the old invalidation and passes with this change.