Repository navigation
fix(protogen): map Python dependency imports - #52
Merged
Merged
Conversation
paralin
force-pushed
the
fix/python-proto-deps
branch
from
August 12, 2026 03:09
17484f7 to
4470038
Compare
Python files generated for one module import dependency schemas through their Go module paths. The dependency wheels install those schemas under module-relative Python packages instead, so a consumer wheel can build successfully and then fail during import. Read module roots from vendor/modules.txt and replace the longest matching prefix with the dependency package path. Require a dot boundary so similarly named and undeclared modules remain unchanged. Include the selected StarPC Python plugin and its frozen uv.lock in the cache fingerprint. Record the new fingerprint only after generation succeeds, and ignore Python lock changes when the Python plugin is not selected. Install uv in CI before the Go suite runs its generated Python import check. Generated cross-module imports now resolve without aliases, and plugin changes cannot reuse stale service code. Signed-off-by: Christian Stewart <christian@aperture.us>
paralin
force-pushed
the
fix/python-proto-deps
branch
from
August 12, 2026 03:15
4470038 to
cd54850
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Python files generated for one module import dependency schemas through their Go module paths. The dependency wheels install those schemas under module-relative Python packages instead, so a consumer wheel can build successfully and then fail during import.
Read module roots from
vendor/modules.txtand replace the longest matching prefix with the dependency package path. Require a dot boundary so similarly named and undeclared modules remain unchanged.Include the selected StarPC Python plugin and its frozen
uv.lockin the cache fingerprint. Record the new fingerprint only after generation succeeds, and ignore Python lock changes when the Python plugin is not selected.Install uv in CI before the Go suite runs its generated Python import check. Generated cross-module imports now resolve without aliases, and plugin changes cannot reuse stale service code.