Repository navigation
fix(tools): restore module hashes for the tool build - #51
Merged
Merged
Conversation
The last dependency update raised golang.org/x/tools to v0.48.0 and golang.org/x/text to v0.40.0 in the tools module but recorded only their go.mod hashes, leaving the previous versions as the sole entries carrying a module hash. Building any tool under .tools then failed under readonly module mode with "missing go.sum entry", which is how aptre builds every linter and generator, so lint and generate stopped working in this repository and in every consumer that extracts this module. Retidy the tools module so each selected version carries its module hash, and copy the result into the embedded go.mod.tools and go.sum.tools that consumers unpack. The retidy also settles an indirect requirement on go-github at the version the graph already selects. Tool versions and behavior are unchanged; only the recorded hashes and one indirect requirement move. Signed-off-by: Christian Stewart <christian@aperture.us>
|
Codex Review: Didn't find any major issues. You're on a roll. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The tools module stopped building. A recent dependency update moved golang.org/x/tools to v0.48.0 and golang.org/x/text to v0.40.0 but recorded only their go.mod hashes, so the selected versions had no module hash in go.sum. Every tool build runs under readonly module mode, which meant golangci-lint, protoc-gen-go-lite, gofumpt and the rest all failed with "missing go.sum entry". That took out lint and generate here and in every repository that unpacks this tools module, and Tests has been red on master since that update.
Retidying the tools module restores a module hash for each selected version, and embed.bash copies the result into go.mod.tools and go.sum.tools, which is what consumers actually extract into their .tools directory. The retidy also settles an indirect go-github requirement on the version the module graph already selects. No tool version or behavior changes.
Verified by building protoc-gen-go-lite, protoc-gen-go-starpc, gofumpt, goimports and golangci-lint from the tools module with -mod=readonly: each one fails on the current master and succeeds here.
@codex review