feat(operations): add read-only manifest context - #191
Conversation
|
Warning Review limit reached
Next review available in: 26 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughThe application now accepts manifest configuration, exposes a loopback-protected read-only manifest endpoint, and renders validated manifest context in the Operations UI. Responses and SSR output allowlist non-secret fields and represent unavailable or invalid manifests with bounded states. ChangesManifest context
Estimated code review effort: 4 (Complex) | ~45 minutes Sequence Diagram(s)sequenceDiagram
participant Operator
participant OperationsUI
participant InstancesRouter
participant ManifestLoader
Operator->>OperationsUI: Request dashboard
OperationsUI->>InstancesRouter: Load project manifest context
InstancesRouter->>ManifestLoader: Load configured manifest
ManifestLoader-->>InstancesRouter: Valid or bounded failure result
InstancesRouter-->>OperationsUI: Allowlisted manifest context
OperationsUI-->>Operator: Render manifest status and summary
Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 2📝 Generate docstrings 💡
🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@tests/odoo_forge_server/test_api.py`:
- Around line 205-229: Update tests/odoo_forge_server/test_api.py lines 205-229
by removing the loaded tracking and exact-list assertion; make its loader return
valid manifest data only for the expected path, while retaining the response
assertions. Update tests/odoo_forge_server/test_composition.py lines 239-273 by
removing locations tracking and its exact-list assertion, keeping the API and
SSR output assertions independent of loader call counts.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: d0d5f7bf-62bc-4fa4-b441-6560bc7cc78b
📒 Files selected for processing (9)
src/odoo_forge_server/app.pysrc/odoo_forge_server/composition.pysrc/odoo_forge_server/routes/instances.pysrc/odoo_forge_server/runtime.pysrc/odoo_forge_server/templates/instances.htmlsrc/odoo_forge_server/views.pytests/odoo_forge_server/test_api.pytests/odoo_forge_server/test_composition.pytests/odoo_forge_server/test_ui.py
Closes #189
Type
Summary
Changes
Test plan
uv run pytest— 1905 passed, 46 deselecteduv run mypy src/odoo_forge_server tests/odoo_forge_serveruv run ruff check src/odoo_forge_server tests/odoo_forge_serverContributor checklist
type:*labelSummary by CodeRabbit