Skip to content

fix(deps): pin the starlette resolution floor to 1.3.1 - #186

Merged
aparragithub merged 1 commit into
mainfrom
fix/starlette-security-floor
Aug 8, 2026
Merged

fix(deps): pin the starlette resolution floor to 1.3.1#186
aparragithub merged 1 commit into
mainfrom
fix/starlette-security-floor

Conversation

@aparragithub

Copy link
Copy Markdown
Owner

Closes #185

Summary

  • Closes all 7 open Dependabot alerts (3 high, 3 moderate, 1 low). Every one of them is the same package: starlette.
  • Resolves starlette 0.46.2 → 1.4.1.
  • The floor lives in [tool.uv] constraint-dependencies, not dependencies, because nothing in this project imports starlette. It arrives transitively through FastAPI, which declares starlette>=0.46.0 with no upper bound, so the resolver could otherwise sit on a vulnerable release indefinitely. Declaring a direct dependency on a package we never import would misstate what the project uses.

FastAPI needs no change: 0.141.1 is the current release and already accepts starlette 1.x.

Changes

File Change
pyproject.toml New [tool.uv] section with constraint-dependencies = ["starlette>=1.3.1"]
uv.lock starlette 0.46.2 → 1.4.1

Test plan

All five gates re-run locally against the upgraded resolution:

Gate Result
uv run pytest -q 1897 passed, 46 deselected, 13 subtests passed — 97% coverage
uv run mypy src no issues in 154 source files
uv run ruff check . passed
uv run ruff format --check . 306 files already formatted
uv run lint-imports 10 contracts kept, 0 broken

Zero test changes were needed, which is the point worth checking in review: a starlette 0.x → 1.x major bump landing with no source edits.

One known warning

The suite now emits a single new warning:

StarletteDeprecationWarning: Using `httpx` with `starlette.testclient` is deprecated; install `httpx2` instead.

It is raised inside fastapi/testclient.py, not our code, and is a deprecation rather than a break. Left alone deliberately: migrating the dev-only httpx pin to httpx2 is FastAPI's call to make first, and chasing it here would widen a security fix into a test-infrastructure change.

FastAPI declares starlette>=0.46.0 with no upper bound, so the resolver
was free to sit on 0.46.2 and its seven open advisories. Nothing here
imports starlette, so the floor goes in constraint-dependencies rather
than in dependencies.
@aparragithub aparragithub added the dependencies Pull requests that update a dependency file label Aug 8, 2026
@coderabbitai

coderabbitai Bot commented Aug 8, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@aparragithub, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 37 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 556a1729-f10f-47ab-814f-51b431a016ee

📥 Commits

Reviewing files that changed from the base of the PR and between 1f21983 and a3e875f.

⛔ Files ignored due to path filters (1)
  • uv.lock is excluded by !**/*.lock, !uv.lock
📒 Files selected for processing (1)
  • pyproject.toml

Comment @coderabbitai help to get the list of available commands.

@aparragithub
aparragithub merged commit dc51eba into main Aug 8, 2026
6 checks passed
@aparragithub
aparragithub deleted the fix/starlette-security-floor branch August 8, 2026 02:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Starlette below 1.3.1 leaves seven open security advisories

1 participant