fix(deps): pin the starlette resolution floor to 1.3.1 - #186
Conversation
FastAPI declares starlette>=0.46.0 with no upper bound, so the resolver was free to sit on 0.46.2 and its seven open advisories. Nothing here imports starlette, so the floor goes in constraint-dependencies rather than in dependencies.
|
Warning Review limit reached
Next review available in: 37 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
Comment |
Closes #185
Summary
starlette.starlette0.46.2 → 1.4.1.[tool.uv] constraint-dependencies, notdependencies, because nothing in this project imports starlette. It arrives transitively through FastAPI, which declaresstarlette>=0.46.0with no upper bound, so the resolver could otherwise sit on a vulnerable release indefinitely. Declaring a direct dependency on a package we never import would misstate what the project uses.FastAPI needs no change: 0.141.1 is the current release and already accepts starlette 1.x.
Changes
pyproject.toml[tool.uv]section withconstraint-dependencies = ["starlette>=1.3.1"]uv.lockTest plan
All five gates re-run locally against the upgraded resolution:
uv run pytest -quv run mypy srcuv run ruff check .uv run ruff format --check .uv run lint-importsZero test changes were needed, which is the point worth checking in review: a starlette 0.x → 1.x major bump landing with no source edits.
One known warning
The suite now emits a single new warning:
It is raised inside
fastapi/testclient.py, not our code, and is a deprecation rather than a break. Left alone deliberately: migrating the dev-onlyhttpxpin tohttpx2is FastAPI's call to make first, and chasing it here would widen a security fix into a test-infrastructure change.