feat(lifecycle): compose the lifecycle service behind an opt-in scheduler gate - #183
Closed
aparragithub wants to merge 1 commit into
Closed
Conversation
…uler gate The lifecycle adapter shipped dormant and unimported. Wire it into server composition sharing the existing registry and ownership authority, with a durable journal and manual execution only: the scheduler gate stays disabled unless explicitly opted in, so composition adds no automatic mutation path.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #181. Final slice of
SP-RESOURCE-LIFECYCLE.What
The PostgreSQL Docker lifecycle adapter shipped in #181 dormant and unimported. This wires it into server composition, sharing the existing instance registry and
LocalOwnershipAuthorityrather than standing up parallel state, and backs it with the durable JSONL journal.Execution stays manual.
EnvLifecycleSchedulerGateis disabled by default and consulted by nothing — opt-in is explicit and exact. Composition therefore adds no automatic mutation path, which is what keeps the manual-default guarantee true rather than merely intended.Coverage
Composed end-to-end tests cover the confirmed-zombie and live-activity paths, PROD report-only, and evidence contradictions, each paired with a zero-prohibited-mutation assertion.
Verification
uv run pytest -quv run mypy srcuv run ruff check .uv run ruff format --check .uv run lint-imports342 changed lines, within the 400-line review budget.
SDD verification: 4/4 requirements, 10/10 scenarios covered, 0 critical.