Skip to content

Convert dom.rename.Test to JUnit - #98

Open
elharo wants to merge 2 commits into
mainfrom
convert-rename-to-junit
Open

Convert dom.rename.Test to JUnit#98
elharo wants to merge 2 commits into
mainfrom
convert-rename-to-junit

Conversation

@elharo

@elharo elharo commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

Convert the dom.rename.Test test harness from a main()-driven to JUnit 3.

  • Extends TestCase
  • Replaces broken Assertion.verify/Assertion.equals calls with proper JUnit assertions
  • Removed command-line arg processing, keeps hardcoded defaults
  • Registered in batchtest in build.xml

@elharo
elharo force-pushed the convert-rename-to-junit branch from 5da1e8b to 73cd904 Compare July 7, 2026 22:03
public void test(Document doc) {
public void doTestRename(Document doc) {

System.out.println("DOM rename Test...");

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

println no longer needed, here or anywhere else

}


System.out.println("done.");

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

println no longer needed, here or anywhere else

@elharo elharo changed the title [XERCESJ-1796] Convert dom.rename.Test to JUnit 3 Convert dom.rename.Test to JUnit 3 Jul 8, 2026
@elharo
elharo force-pushed the convert-rename-to-junit branch 2 times, most recently from f7ae425 to b01feae Compare July 8, 2026 12:01
@elharo elharo changed the title Convert dom.rename.Test to JUnit 3 Convert dom.rename.Test to JUnit Jul 8, 2026
@elharo
elharo force-pushed the convert-rename-to-junit branch 2 times, most recently from 90e8c79 to 147e793 Compare July 8, 2026 19:55
}

/** Performs the actual test. */
public void doTestRename(Document doc) {

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

inline this into testRename

@elharo
elharo force-pushed the convert-rename-to-junit branch from 147e793 to a3b1c12 Compare July 8, 2026 20:25
@elharo
elharo requested a review from mrglavas July 8, 2026 20:29

@mrglavas mrglavas left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elharo
elharo force-pushed the convert-rename-to-junit branch from 44e8af3 to c3fc492 Compare July 17, 2026 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants