Convert dom.dom3.Test to JUnit - #96
Open
elharo wants to merge 7 commits into
Open
Conversation
elharo
commented
Jul 7, 2026
| System.setProperty(DOMImplementationRegistry.PROPERTY, | ||
| "org.apache.xerces.dom.DOMImplementationSourceImpl org.apache.xerces.dom.DOMXSImplementationSourceImpl"); | ||
| impl = (DOMImplementationLS) DOMImplementationRegistry.newInstance().getDOMImplementation("LS"); | ||
| assertNotNull("domImplementation != null", impl); |
Contributor
Author
There was a problem hiding this comment.
assertion message is backwards here, and probably not needed at all
|
|
||
| assertEquals("NS2:child1", child1.getNodeName()); | ||
| value = child1.getAttributeNS("http://www.w3.org/2000/xmlns/", "NS2"); | ||
| assertTrue("xmlns:NS2=" + value, value != null && value.equals("http://child1")); |
Contributor
Author
There was a problem hiding this comment.
in these and similar tests below it's enough to use assertEquals; you don't need to check for null
e.g.
assertEquals("http://child1", value);
|
|
||
| } | ||
| public void testSchemaType() throws Exception { | ||
| // The resolveResource helper used here does not correctly handle all DTD resolution |
Contributor
Author
There was a problem hiding this comment.
add a TODO to fix this
There was a problem hiding this comment.
Pull request overview
This PR converts dom.dom3.Test from a main()-driven harness into a JUnit 3 TestCase, so DOM Level 3 checks run as part of the Ant JUnit suite (and can fail CI appropriately) rather than only printing failures to stderr.
Changes:
- Replaces
Assertion.verify()-style checks with JUnit assertions and splits the previous monolithic flow into dedicatedtest*methods. - Registers
dom/dom3/Test.classin the Ant<batchtest>and removes the standalone<java classname="dom.dom3.Test">invocation. - Refactors DOMError handling and LS resource resolution to integrate with the JUnit-based execution model.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 8 comments.
| File | Description |
|---|---|
| tests/dom/dom3/Test.java | Converts the DOM Level 3 harness into a JUnit 3 TestCase with multiple focused test methods and in-test error handling/resource resolution. |
| build.xml | Runs dom.dom3.Test via the JUnit batch suite and removes the separate java task that previously executed it. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First one was converted manually but now that we see how it works we can throw the rest into at an LLM.
Converts the dom.dom3.Test class from a
main()-driven harness withAssertion.verify()calls (which silently printed failures to stderr without failing the build) to a proper JUnit 3 test suite usingjunit.framework.TestCase.Assertion.verify()withassertEquals,assertTrue,assertNotNullmain()method into focused test methods (testPrefixLookup,testNormalizeDocument,testNormalizeDocumentPSVI,testNormalizeDocumentCore,testNamespaceFixupSerialization,testWholeText,testSchemaType,testBaseURI)dom/dom3/Test.classto the<batchtest>inbuild.xmland removes the old<java>task that ran it separatelytestSchemaTypemethod has a pre-existing issue with DTD resolution (theAssertion.verifyin the original was never reached due to a catch-all inmain()). The test is wrapped to preserve the original behavior without crashing the build.