Fix UnparsedEntityCheckingTest: remove leftover RuntimeException - #115
Open
elharo wants to merge 2 commits into
Open
Fix UnparsedEntityCheckingTest: remove leftover RuntimeException#115elharo wants to merge 2 commits into
elharo wants to merge 2 commits into
Conversation
… testDefaultValid
elharo
commented
Jul 17, 2026
Contributor
Author
There was a problem hiding this comment.
The try-catch can be removed. If an exception is thrown the test fails. No try-catch is needed
elharo
commented
Jul 17, 2026
elharo
left a comment
elharo
left a comment
Contributor
Author
There was a problem hiding this comment.
Removed try-catch blocks from all test methods. Exceptions now propagate naturally to JUnit.
Contributor
Author
|
Removed try-catch blocks from all test methods in response to review feedback. Exceptions now propagate naturally to JUnit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
testDefaultValid()inUnparsedEntityCheckingTesthad a leftoverthrow new RuntimeException();aftercheckDefault()at line 58, which caused the test to always fail with an error.This was likely left over from development/debugging. Removed the throw statement so the test properly passes when validation succeeds.