Fix IgnoreXSIType and UseGrammarPoolOnly test assertions (VALIDATION_NONE -> VALIDATION_PARTIAL) - #114
Open
elharo wants to merge 2 commits into
Open
Fix IgnoreXSIType and UseGrammarPoolOnly test assertions (VALIDATION_NONE -> VALIDATION_PARTIAL)#114elharo wants to merge 2 commits into
elharo wants to merge 2 commits into
Conversation
elharo
force-pushed
the
fix-commented-out-tests
branch
from
July 17, 2026 15:00
8ba6e6a to
79e45c3
Compare
There was a problem hiding this comment.
Pull request overview
This pull request updates schema configuration tests to assert VALIDATION_PARTIAL (instead of VALIDATION_NONE) when attribute validation occurs via the anyType wildcard, and re-enables the corrected tests in the Ant test suite.
Changes:
- Adjust PSVI
validationAttemptedexpectations fromVALIDATION_NONEtoVALIDATION_PARTIALin the affected config tests. - Remove an unconditional
RuntimeExceptionfromUnparsedEntityCheckingTest. - Re-enable the fixed tests in
build.xmlwhile keeping still-failing tests commented out.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/schema/config/UseGrammarPoolOnly_True_Test.java | Updates root PSVI validationAttempted assertion to expect VALIDATION_PARTIAL. |
| tests/schema/config/IgnoreXSIType_C_CA_Test.java | Updates child element PSVI validationAttempted assertion to expect VALIDATION_PARTIAL. |
| tests/schema/config/IgnoreXSIType_C_C_Test.java | Updates root and child PSVI validationAttempted assertions to expect VALIDATION_PARTIAL. |
| tests/schema/config/IgnoreXSIType_C_AC_Test.java | Updates child element PSVI validationAttempted assertion to expect VALIDATION_PARTIAL. |
| tests/schema/config/UnparsedEntityCheckingTest.java | Removes an unconditional runtime failure so the test can execute normally when run. |
| build.xml | Re-enables the fixed tests in the junit batch and keeps other known-failing tests commented out. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+844
to
+848
| <!-- These tests still need fixes: | ||
| <include name="schema/config/UnparsedEntityCheckingTest.class"/> | ||
| <include name="schema/config/SurrogatePairLengthTest.class"/> | ||
| --> | ||
| <include name="jaxp/JAXPSpecTest.class"/> |
Comment on lines
+839
to
+843
| <include name="schema/config/UseGrammarPoolOnly_False_Test.class"/> | ||
| <!-- These tests are failing. Fix them. | ||
| <include name="schema/config/IgnoreXSIType_C_AC_Test.class"/> | ||
| <include name="schema/config/IgnoreXSIType_C_CA_Test.class"/> | ||
| <include name="schema/config/IgnoreXSIType_C_C_Test.class"/> | ||
| <include name="schema/config/SurrogatePairLengthTest.class"/> | ||
| <include name="schema/config/UseGrammarPoolOnly_True_Test.class"/> | ||
| <include name="schema/config/UnparsedEntityCheckingTest.class"/> | ||
| --> | ||
| <include name="jaxp/JAXPSpecTest.class"/> | ||
| <include name="schema/config/IgnoreXSIType_C_AC_Test.class"/> | ||
| <include name="schema/config/IgnoreXSIType_C_CA_Test.class"/> | ||
| <include name="schema/config/IgnoreXSIType_C_C_Test.class"/> | ||
| <include name="schema/config/UseGrammarPoolOnly_True_Test.class"/> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes 4 commented-out schema config tests that had incorrect assertion expectations.
Root cause: All four tests expected
VALIDATION_NONEfor elements with declared attributes (e.g.,attr="typeY"). Attribute validation via the anyType wildcard producesVALIDATION_PARTIAL, notVALIDATION_NONE.IgnoreXSIType_C_AC_Test— root and child 2 assertions changed fromNONEtoPARTIALIgnoreXSIType_C_CA_Test— root and child 1 assertions changed fromNONEtoPARTIALIgnoreXSIType_C_C_Test— root and child assertions changed fromNONEtoPARTIALUseGrammarPoolOnly_True_Test— root assertion changed fromNONEtoPARTIALThe IGNORE_XSI_TYPE and USE_GRAMMAR_POOL_ONLY features themselves work correctly; the test assertions were wrong.