Convert xinclude.Test to JUnit - #113
Open
elharo wants to merge 4 commits into
Open
Conversation
elharo
commented
Jul 8, 2026
| /** | ||
| * Tests for XInclude implementation. | ||
| * Use -f option to see the error message log | ||
| * @author Peter McCracken, IBM |
| protected static final String ERROR_HANDLER = | ||
| "http://apache.org/xml/properties/internal/error-handler"; | ||
|
|
||
| // this array contains whether the test number NN (contained in file testNN.xml) |
Contributor
Author
There was a problem hiding this comment.
This comment is useful and should be retained
| parserConfig.setFeature(SCHEMA_FULL_CHECKING_FEATURE_ID, true); | ||
| fWriter = new Writer(parserConfig); | ||
|
|
||
| // this has to be done AFTER fWriter is created |
Contributor
Author
There was a problem hiding this comment.
This comment is useful and should be retained
| // strip ones in URI form | ||
| while ((start = str.indexOf(userURI, start)) != -1) { | ||
| end = start + userURI.length(); | ||
| // we add one, to get rid of the '/' after the user directory path |
Contributor
Author
There was a problem hiding this comment.
This comment is useful and should be retained
| String str = getPathWithoutEscapes(buf.toString()); | ||
|
|
||
| int start = 0, end = 0; | ||
| // strip ones in URI form |
Contributor
Author
There was a problem hiding this comment.
This comment is useful and should be retained
|
|
||
| while ((start = str.indexOf(userDir, start)) != -1) { | ||
| end = start + userDir.length(); | ||
| // we add one, to get rid of the '/' after the user directory path |
Contributor
Author
There was a problem hiding this comment.
This comment is useful and should be retained
elharo
force-pushed
the
convert-xinclude-to-junit
branch
from
July 8, 2026 12:47
2e13a19 to
9d9b14e
Compare
Contributor
Author
|
All review comments addressed: restored @author tag, test results comments, fWriter creation comment, and stripUserDir comments. |
elharo
changed the title
elharo
force-pushed
the
convert-xinclude-to-junit
branch
2 times, most recently
from
July 8, 2026 20:21
59407cb to
d6fc886
Compare
elharo
force-pushed
the
convert-xinclude-to-junit
branch
from
July 16, 2026 14:33
43464ef to
18f4ee5
Compare
…Writer creation comment, and stripUserDir comments
elharo
force-pushed
the
convert-xinclude-to-junit
branch
from
July 19, 2026 12:10
4e21ccd to
0af9a3d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Converts the xinclude test harness from main()-driven to JUnit 3.