Convert dom.mem.Test to JUnit - #104
Open
elharo wants to merge 3 commits into
Open
Conversation
elharo
force-pushed
the
convert-mem-to-junit
branch
from
July 7, 2026 22:04
d52fa76 to
95b8ea5
Compare
elharo
changed the title
elharo
force-pushed
the
convert-mem-to-junit
branch
from
July 16, 2026 14:41
023d3b2 to
a546f86
Compare
mrglavas
reviewed
Jul 17, 2026
Comment on lines
+369
to
+370
| assertNull(nnm); | ||
| assertNull(nnm); |
mrglavas
reviewed
Jul 17, 2026
Comment on lines
+439
to
+440
| assertNull(nl); | ||
| assertNull(nl); |
There was a problem hiding this comment.
Same comment here about redundant checks.
elharo
commented
Jul 17, 2026
| Assertion.verify(dst != null && | ||
| dst.getNodeType() == fNode.getNodeType()); | ||
| assertEquals(UserDataHandler.NODE_CLONED, operation); | ||
| assertTrue(key == fKey && data == fData && src == fNode); |
Contributor
Author
There was a problem hiding this comment.
This should be split into three assertEquals or assertSame checks
| dst.getNodeType() == fNode.getNodeType()); | ||
| assertEquals(UserDataHandler.NODE_CLONED, operation); | ||
| assertTrue(key == fKey && data == fData && src == fNode); | ||
| assertTrue(dst != null && dst.getNodeType() == fNode.getNodeType()); |
Contributor
Author
There was a problem hiding this comment.
This can be one assertEquals check. null check does not need to be explicit
Contributor
Author
|
Addressed review comments:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Convert the dom.mem.Test test harness from a main()-driven to JUnit 3.