Skip to content

Convert dom.range.Test to JUnit - #100

Open
elharo wants to merge 2 commits into
mainfrom
convert-range-to-junit
Open

Convert dom.range.Test to JUnit#100
elharo wants to merge 2 commits into
mainfrom
convert-range-to-junit

Conversation

@elharo

@elharo elharo commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

Convert the dom.range.Test test harness from a main()-driven to JUnit 3.

  • Extends TestCase with individual test methods for delete, extract, clone, insert, surround, insert2, delete2
  • Replaced manual string comparison with JUnit assertions
  • Registered in batchtest and old java task removed in build.xml

@elharo
elharo force-pushed the convert-range-to-junit branch from 9034a02 to 23f769e Compare July 7, 2026 22:04
@elharo elharo changed the title [XERCESJ-1796] Convert dom.range.Test to JUnit 3 Convert dom.range.Test to JUnit 3 Jul 8, 2026
@elharo
elharo marked this pull request as draft July 8, 2026 14:59
@elharo
elharo force-pushed the convert-range-to-junit branch from 23f769e to 0957c27 Compare July 8, 2026 18:36
@elharo
elharo marked this pull request as ready for review July 8, 2026 18:41
@elharo
elharo requested a review from mrglavas July 8, 2026 18:41
@elharo elharo changed the title Convert dom.range.Test to JUnit 3 Convert dom.range.Test to JUnit Jul 8, 2026
Comment thread build.xml Outdated
Comment on lines +919 to +931
<<<<<<< HEAD
<echo message="Running dom.ids.Test..." />
<java fork="yes"
classname="dom.ids.Test"
classpathref="test.classpath"
failOnError="yes">
=======
<java fork="yes"
classname="dom.range.Test"
classpathref="test.classpath"
failOnError="yes">
<arg value="all"/>
>>>>>>> main

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a merge conflict that you were attempting to resolve. The build is failing because of this.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, the various conversions all hit the same few lines in the build.xml file. As son as one merges, the others need to be resolved.

@elharo
elharo force-pushed the convert-range-to-junit branch from 5304ecc to 2245178 Compare July 19, 2026 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants