TIKA-4630 -- Use name from gzip metadata if available, use name as internal path #2553
+45
−27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tballison
reviewed
Jan 27, 2026
| public void testTarballWithoutGzipNameMetadata() throws Exception { | ||
| List<Metadata> list = getRecursiveMetadata("test-documents-no-name-metadata.tgz"); | ||
| Metadata last = list.get(list.size() - 1); | ||
| String internalPath = last.get(TikaCoreProperties.INTERNAL_PATH); |
Contributor
There was a problem hiding this comment.
The point of internal_path is to store what the file contained about the internal path of a resource. This metadata field should tell the user "this was the path that was literally stored in the container file. Tika did no guesswork here".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A previous change related to the same JIRA means that INTERNAL_PATH is set using the metadata name from a gzip file. However, many gzips don't have this data. Also other archives like bz2 won't have the data. This PR does two things (1) gets the RESOURCE_NAME from the gzip metadata if possible (a change from existing behaviour) and (2), in the absence of a name in the gzip metadata (due to it not being there in a gzip, or another format such as bzip being used), sets the INTERNAL_PATH to be the same as RESOURCE_NAME