Repository navigation
THRIFT-6409: Preserve nested empty-list values in Node.js TJSONProtocol - #4054
Merged
Merged
Conversation
Client: js Generated-by: Pi 1.4.0 (openai-codex/gpt-6-luna)
Member
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. 🤖 Generated with Claude Code |
3 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes THRIFT-6409.
readListEndpreviously popped only one stack entry. When a nested list was empty, the child value and empty list frame remained above the parent; subsequent sibling values could be read from the wrong stack frame. Restore the stack to the parent collection before advancing it.Adds synthetic Node.js TJSONProtocol regressions for nested lists and map values containing empty nested lists, and registers the test in
lib/nodejs/test/testAll.sh.Verification:
node lib/nodejs/test/json_nested_empty_lists.test.js— 4 assertions passed.git diff --check— passed.testAll.shsuite was not run: this Windows host has no Thrift compiler ormakeavailable to generate and run the broader protocol tests.json_protocol.jsreport pre-existing legacy ES5/style and line-ending issues across unchanged code; no repository-wide formatting was applied.No CI status was queried.
Generated-by: Pi 1.4.0 (openai-codex/gpt-6-luna)