Skip to content

[fix][io] Fix delayed acknowledgment for offset 0 in Kafka Connect Adapter #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dlg99 merged 2 commits into from
May 11, 2026
+5 −1
Merged

[fix][io] Fix delayed acknowledgment for offset 0 in Kafka Connect Adapter #24

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8661efd
offsets check is updated and test is added
sandeep-mst May 6, 2026
0f5d97b
updated the test for checking the offset value returned
sandeep-mst May 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...-adaptor/src/main/java/org/apache/pulsar/io/kafka/connect/PulsarKafkaSinkTaskContext.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@ private Long currentOffset(TopicPartition topicPartition) {
public Map<TopicPartition, OffsetAndMetadata> currentOffsets() {
Map<TopicPartition, OffsetAndMetadata> snapshot = Maps.newHashMapWithExpectedSize(currentOffsets.size());
currentOffsets.forEach((topicPartition, offset) -> {
if (offset > 0) {
if (offset >= 0) {
snapshot.put(topicPartition,
new OffsetAndMetadata(offset, Optional.empty(), null));
}
Expand Down
4 changes: 4 additions & 0 deletions ...onnect-adaptor/src/test/java/org/apache/pulsar/io/kafka/connect/KafkaConnectSinkTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1207,6 +1207,10 @@ public void offsetTest() throws Exception {

// offset is 0 for the first written record
assertEquals(sink.currentOffset(topicName, partition), 0);
// current offsets map returned by the PulsarKafkaSinkTaskContext should contain the record with offset 0
assertEquals(
sink.taskContext.currentOffsets().get(new TopicPartition(topicName, partition)).offset(), 0
);

entryId.set(1);
sink.write(record);
Expand Down