Fix Excel's Accounting Format for zero part where 0 is randomly added at the end#888
Open
dat07cs wants to merge 1 commit intoapache:trunkfrom
Open
Fix Excel's Accounting Format for zero part where 0 is randomly added at the end#888dat07cs wants to merge 1 commit intoapache:trunkfrom
dat07cs wants to merge 1 commit intoapache:trunkfrom
Conversation
Member
|
The existing code is very complicated. The new changes make it even more complicated. It does appear to fix 2 asserts in the tests so that is good and doesn't appear to break anything. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an attempt to try to handle a common case where
?is used as alignment placeholder.Given the custom number format for zero:
_-$* \"-\"??_-Current formatted value:
- 0<4 spaces><literal-dash><space><zero><space>Expected formatted value:
-(<4 spaces><literal-dash><3 spaces>)