Spelling by jsoref · Pull Request #480 · apache/poi

jsoref · 2023-06-23T20:45:22Z

This PR corrects misspellings identified by the check-spelling action.

The misspellings have been reported at https://github.com/jsoref/poi/actions/runs/5360105495#summary-14513021500

The action reports that the changes in this PR would make it happy: https://github.com/check-spelling/poi/actions/runs/5360101471#summary-14513009039

jsoref

Some of the changes were automatically suggested by Google Sheets. A large portion of them were me applying other corrections or manually applying corrections. All fault mine.

jsoref · 2023-06-23T20:45:38Z

build.gradle

                    // opposed to the recommendation there, it doesn't work to add ... to the dependencies
                    // testRuntimeOnly 'org.junit.platform:junit-platform-launcher:1.7.1'
-                    // gradles gradle-worker.jar is still not a JPMS module and thus runs as unnamed module
+                    // gradle's gradle-worker.jar is still not a JPMS module and thus runs as unnamed module


jsoref · 2023-06-23T20:45:45Z

build.gradle

        // for documentation of properties.
        //
-        // Some additional properties are currently set in the Jenkins-DSL, see jenksin/create_jobs.groovy
+        // Some additional properties are currently set in the Jenkins-DSL, see jenkins/create_jobs.groovy


jsoref · 2023-06-23T20:46:20Z

build.xml

        <download-line prop="li4" dist="src" pack="zip"/>

-<echo file="download-snipplet.xml"><![CDATA[
+<echo file="download-snippet.xml"><![CDATA[


dunno if something cares about the filename...

jsoref · 2023-06-23T20:49:05Z

poi-ooxml/src/main/java/org/apache/poi/xslf/util/PPTX2PNG.java

                    return new SVGFormat(textAsShapes);
                } catch (Exception | NoClassDefFoundError e) {
-                    LOG.atError().withThrowable(e).log("Batik is not not added to/working on the module-path. Use classpath mode instead of JPMS. Fallback to PNG.");
+                    LOG.atError().withThrowable(e).log("Batik is not added to/working on the module-path. Use classpath mode instead of JPMS. Fallback to PNG.");


doubled words have been historically flagged by spell checking tools... doubled negatives are problematic...

jsoref · 2023-06-23T20:49:32Z

poi-ooxml/src/main/java/org/apache/poi/xssf/usermodel/XSSFDrawing.java

        graphicFrame.setAnchor(anchor);
        graphicFrame.setId(frameId);
-        graphicFrame.setName("Diagramm" + frameId);
+        graphicFrame.setName("Diagram" + frameId);


is this an api break?

poi/src/test/java/org/apache/poi/hssf/usermodel/TestHSSFSheet.java

jsoref · 2023-06-23T21:25:30Z

poi/src/test/java/org/apache/poi/poifs/dev/TestPOIFSDump.java

-                "SecurityManager does not work any more since JDK 18");
+                "SecurityManager does not work since JDK 18");


in principle, this should be anymore, but in practice, it's superfluous, so I removed it.

jsoref · 2023-06-23T21:26:27Z

poi/src/test/java/org/apache/poi/poifs/filesystem/TestPOIFSFileSystem.java

-     *  not not issue an EOF when we discover the last block
+     *  not to issue an EOF when we discover the last block


or to not, but I think this is the right change...

poi/src/test/java/org/apache/poi/ss/formula/atp/TestWorkdayFunction.java

jsoref · 2023-06-23T21:29:33Z

poi/src/test/java/org/apache/poi/ss/usermodel/BaseTestRow.java

-        //  that that is now used if no policy given
+        //  that it is now used if no policy given


atypical correction

poi-ooxml/src/main/java/org/apache/poi/xwpf/usermodel/XWPFRun.java

jsoref · 2023-06-24T00:40:41Z

poi/src/test/java/org/apache/poi/hssf/extractor/TestExcelExtractor.java

+            assertEquals("Sheet1\nI have lots of embeded files in me\nSheet2\nSheet3\n", ex.getText()); /* fixing the spelling here requires editing 44643.xls */
+            assertEquals("Excel With Embeded", ex.getSummaryInformation().getTitle()); /* fixing the spelling here requires editing 44643.xls */


I'm leaving these here. I'm not sure I have access to the right version of Excel to update the files. But I suspect that the rest of the changes for this commit are ok.

jsoref · 2023-06-24T00:45:49Z

It's possible everything else is ok. I'm done for the weekend. I'll check back sometime next week.

Thanks for the prompt response. I should have looked at the workflows more carefully, I missed that there was a pull_request: branches: trunk -- I'm used to CI that either doesn't exist (which is what I assumed based on the lack of any feedback in my personal PR) or that doesn't care about the target branch, in which case my personal PR would have triggered it and I would have worked w/ it until it was green before making this PR.

jsoref · 2023-06-24T00:47:52Z

I've currently dropped spelling: secret, but I'm testing a fixed version of it in check-spelling-sandbox#2

jsoref · 2023-06-25T05:20:17Z

I can't figure out where the setCurrentUserPasswort comes from...

      Test #309 document/PasswordProtected.doc HWPF FAILED (1.2s)

      org.opentest4j.AssertionFailedError: document/PasswordProtected.doc - failed. Message: document is encrypted, password is invalid - use Biff8EncryptionKey.setCurrentUserPassword() to set password before opening - didn't contain: document is encrypted, password is invalid - use Biff8EncryptionKey.setCurrentUserPasswort() to set password before opening ==> expected: <true> but was: <false>
          at app/org.apache.poi.stress/org.apache.poi.stress.TestAllFiles.verify(TestAllFiles.java:259)

pjfanning

-1 from me

PR is much too big
changes data used in tests that can break tests
changes file names
changes API - we can't just remove a rename a public method - we need to deprecate it and add a new method with the corrected name - mark deprecations and since flags

I've applied a few low risk changes. It is not a priority for me to keep applying more.

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

jsoref · 2023-06-27T12:02:30Z

Thanks, I'm happy to split out other pieces, e.g. perhaps things that don't rename files / apis / test data...

pjfanning · 2023-06-27T12:23:19Z

Thanks @jsoref - I'm not 100% sure this is worth the effort. This is not even a live repo - the real code is in a subversion repo. So applying PRs to our code is very manual and time consuming.

Over time, I can come back to this PR and grab a couple more changes and apply them myself.

jsoref · 2023-06-27T12:29:28Z

Yeah, I noticed the svn bits.

Anyway, thanks for working on this and the project in general. My employer uses this library :)

Some suggested changes are too invasive so we can only pick some changes semi-automatically git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1922678 13f79535-47bb-0310-9956-ffa450edef68

jsoref commented Jun 23, 2023

View reviewed changes

pjfanning reviewed Jun 23, 2023

View reviewed changes

poi-ooxml/src/main/java/org/apache/poi/xwpf/usermodel/XWPFRun.java Outdated Show resolved Hide resolved

jsoref force-pushed the spelling branch 3 times, most recently from 014c79e to 5fa0530 Compare June 24, 2023 00:39

jsoref commented Jun 24, 2023

View reviewed changes

jsoref force-pushed the spelling branch from 5fa0530 to 12858ca Compare June 24, 2023 00:41

jsoref marked this pull request as ready for review June 24, 2023 00:43

jsoref requested a review from pjfanning June 24, 2023 00:43

jsoref force-pushed the spelling branch from 12858ca to 8a76c4e Compare June 25, 2023 03:35

jsoref force-pushed the spelling branch from 8a76c4e to a20cd55 Compare June 26, 2023 02:31

pjfanning requested changes Jun 27, 2023

View reviewed changes

jsoref added 15 commits June 27, 2023 08:00

spelling: data

b4e36d3

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: decoration

fa952d7

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: decrement

b426480

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: decrypted

d0b6852

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: default

ffb9ffd

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: defaults

cece5a7

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: deferred

9203418

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: defined

cadf03b

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: definition

d23f28d

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: degrees

ab59a9e

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: delete

33ce9cc

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: deleting

773bed6

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: described

33b1bc8

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: details

3e40197

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: diagonal

0781bad

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

jsoref added 25 commits June 27, 2023 08:00

spelling: unevaluable

ad7e898

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: unnecessary

77b354a

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: unparsable

a572e5d

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: unset

c9d0f73

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: us

f78510a

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: usage

d691bf0

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: value

8d4417d

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: verifier

7cba88b

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: verify

4dd8abc

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: version

7765b25

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: vertical

c3a8dcd

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: weight

63ba12a

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: were

4083671

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: while

4fb0e15

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: width

a7098d3

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: with-text

da52d5e

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: with

d2452dc

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: woohoo

e4bd729

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: workaround

fabc363

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: workbook

4105c35

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: writing

02afc86

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: written and

bfde088

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: xslx

f91be07

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: xwpfwordextractor

a792818

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: zhang

852fb50

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

jsoref force-pushed the spelling branch from a20cd55 to 852fb50 Compare June 27, 2023 12:01

		"SecurityManager does not work any more since JDK 18");
		"SecurityManager does not work since JDK 18");

		* not not issue an EOF when we discover the last block
		* not to issue an EOF when we discover the last block

		// that that is now used if no policy given
		// that it is now used if no policy given

		assertEquals("Sheet1\nI have lots of embeded files in me\nSheet2\nSheet3\n", ex.getText()); /* fixing the spelling here requires editing 44643.xls */
		assertEquals("Excel With Embeded", ex.getSummaryInformation().getTitle()); /* fixing the spelling here requires editing 44643.xls */

Conversation

jsoref commented Jun 23, 2023

Uh oh!

jsoref left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jsoref commented Jun 24, 2023

Uh oh!

jsoref commented Jun 24, 2023

Uh oh!

jsoref commented Jun 25, 2023

Uh oh!

pjfanning left a comment

Choose a reason for hiding this comment

Uh oh!

jsoref commented Jun 27, 2023

Uh oh!

pjfanning commented Jun 27, 2023

Uh oh!

jsoref commented Jun 27, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants