-
Notifications
You must be signed in to change notification settings - Fork 588
HDDS-12855. Update NOTICE-ratis-thirdparty-misc.txt #9543
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
cchung100m
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks to @0lai0
szetszwo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@0lai0 , thanks for working on this!
Just a question -- is NOTICE-ratis-thirdparty-misc.txt supposed to be the same as https://github.com/apache/ratis-thirdparty/blob/1.0.10/NOTICE ?
I guess it should be like NOTICE in (This is in Based on that, it LGTM. |
|
How the bundled dependencies are selected? Why the other bundled dependencies (such as guava) are not selected? |
I have no idea, but this part of |
What changes were proposed in this pull request?
This PR updates the
NOTICE-ratis-thirdparty-misc.txtfile to synchronize it with the latest NOTICE file from the upstream ratis-thirdparty project version 1.0.10.What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-12855