Skip to content

system/readline: update stale tab_completion description - #4046

Merged
xiaoxiang781216 merged 1 commit into
apache:masterfrom
Junbo-Zheng:nsh
Nov 13, 2026
Merged

xiaoxiang781216 merged 1 commit into
apache:masterfrom
Junbo-Zheng:nsh

Conversation

@Junbo-Zheng

Copy link
Copy Markdown
Contributor

Summary

The commit adding path completion for command arguments (3482518,
PR #4010) made TAB complete the last word of the line against directory
entries before falling back to builtin command names, but the
tab_completion() header comment was left saying "Unix like tab
completion, only for builtin apps". This updates the description to
match the actual two-level behavior.

Impact

  • Users: None -- comment-only change, no code or behavior change.
  • Build: None.
  • Hardware: None.
  • Documentation: None
  • Security & Compatibility: None.

Testing

sim:nsh

Signed-off-by: Junbo Zheng <zhengjunbo1@xiaomi.com>

The commit adding path completion for command arguments (3482518,
PR apache#4010) made TAB complete the last word of the line against directory
entries before falling back to builtin command names, but the
tab_completion() header comment was left saying "only for builtin apps".
Update the description to match the actual two-level behavior.

Signed-off-by: Junbo Zheng <zhengjunbo1@xiaomi.com>
@xiaoxiang781216
xiaoxiang781216 merged commit 286c810 into apache:master Nov 13, 2026
15 of 41 checks passed
@Junbo-Zheng
Junbo-Zheng deleted the nsh branch November 13, 2026 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants