Repository navigation
system/readline: update stale tab_completion description - #4046
Merged
Merged
Conversation
The commit adding path completion for command arguments (3482518, PR apache#4010) made TAB complete the last word of the line against directory entries before falling back to builtin command names, but the tab_completion() header comment was left saying "only for builtin apps". Update the description to match the actual two-level behavior. Signed-off-by: Junbo Zheng <zhengjunbo1@xiaomi.com>
yushuailong
approved these changes
Nov 13, 2026
GUIDINGLI
approved these changes
Nov 13, 2026
xiaoxiang781216
approved these changes
Nov 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The commit adding path completion for command arguments (3482518,
PR #4010) made TAB complete the last word of the line against directory
entries before falling back to builtin command names, but the
tab_completion()header comment was left saying "Unix like tabcompletion, only for builtin apps". This updates the description to
match the actual two-level behavior.
Impact
Testing
sim:nsh
Signed-off-by: Junbo Zheng <zhengjunbo1@xiaomi.com>