Repository navigation
nxboot: support watchdog ping during FW update - #4044
Merged
Merged
Conversation
michallenc
requested review from
acassis,
cederom,
jerpelea,
linguini1 and
xiaoxiang781216
November 12, 2026 18:15
cederom
previously approved these changes
Nov 12, 2026
cederom
left a comment
Contributor
There was a problem hiding this comment.
Thank you @michallenc :-)
michallenc
force-pushed
the
nxboot-wd
branch
from
November 13, 2026 07:53
099eb59 to
0c2e42e
Compare
The application might need to ping the watchdog during update. Add support for pinging if NXBOOT_WATCHDOG is enabled. This has no effect on current usage, the behavior is the same if NXBOOT_WATCHDOG is disabled. Signed-off-by: Michal Lenc <michallenc@seznam.cz>
michallenc
force-pushed
the
nxboot-wd
branch
from
November 13, 2026 07:53
0c2e42e to
b0acc46
Compare
michallenc
marked this pull request as ready for review
November 13, 2026 08:19
xiaoxiang781216
approved these changes
Nov 13, 2026
acassis
approved these changes
Nov 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The application might need to ping the watchdog during update. Add support for pinging if
NXBOOT_WATCHDOGis enabled.This has no effect on current usage, the behavior is the same if
NXBOOT_WATCHDOGis disabled.Impact
None as
NXBOOT_WATCHDOGis disabled by default.Testing
Both builds with enabled and disabled option pass. Watchdog is pinged if enabled and long update is successful.
I am marking this as a draft now as i'd like to do some more tests tomorrow morning. But the idea behind the code is final.