Repository navigation
testing/ostest: Check the interrupt stack of each CPU. - #3982
Merged
Merged
Conversation
With CONFIG_STACK_COLORATION, each CPU takes an interrupt, then up_check_intstack() must show some use and some color left. A CPU whose stack was never colored reports that all of it is used. Assisted-by: Claude Code:claude-opus-5-5 Signed-off-by: Marco Casaroli <marco.casaroli@gmail.com>
cederom
approved these changes
Nov 5, 2026
xiaoxiang781216
approved these changes
Nov 6, 2026
casaroli
marked this pull request as ready for review
November 6, 2026 11:53
acassis
approved these changes
Nov 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
With
CONFIG_STACK_COLORATION, ostest now checks the interrupt stack of each CPU: the CPU takes an interrupt, thenup_check_intstack()must show some use and some color left. A stack with no color reports that all of it is used.Impact
ostest only, in flat SMP builds with
CONFIG_STACK_COLORATION. Boards with rp23xx SMP and this option need apache/nuttx#21463, which colors the stack there.Testing
On master, QEMU, ostest status 0: qemu-armv8a:nsh_smp, 2 CPUs, used 880 and 560 of 8192; rv-virt:smp, 8 CPUs, used 220 of 2048 on each (
up_check_intstack()of RISC-V does not use its CPU argument).tools/checkpatch.sh -c -u -m -gpasses.