Repository navigation
Fastboot optimization - #3238
Merged
Merged
Conversation
Bring up the network when do fastboot tcp init. Signed-off-by: yangsong8 <yangsong8@xiaomi.com>
add an interface fastboot_handler. This interface can be called when nsh is disable. Signed-off-by: yangsong8 <yangsong8@xiaomi.com>
The switchboot command can be sent even without enabling sh Signed-off-by: yangsong8 <yangsong8@xiaomi.com>
apps/system/fastboot/fastboot.c:351:43: error: '%s' directive output may be truncated writing up to 63 bytes into a region of size 60 [-Werror=format-truncation=] ...... apps/system/fastboot/fastboot.c:351:3: note: 'snprintf' output between 5 and 68 bytes into a destination of size 64 | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ apps/system/fastboot/fastboot.c:351:43: error: '%s' directive output may be truncated writing up to 63 bytes into a region of size 60 [-Werror=format-truncation=] ...... apps/system/fastboot/fastboot.c:351:3: note: 'snprintf' output between 5 and 68 bytes into a destination of size 64 | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Signed-off-by: yangsong8 <yangsong8@xiaomi.com>
cederom
requested review from
acassis,
cederom,
jerpelea,
linguini1 and
xiaoxiang781216
December 8, 2025 16:57
acassis
approved these changes
Dec 8, 2025
xiaoxiang781216
approved these changes
Dec 8, 2025
cederom
approved these changes
Dec 8, 2025
cederom
left a comment
Contributor
There was a problem hiding this comment.
Thank you @yangsong8-a1 :-)
Lets just wait for the CI to complete :-)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
If using TCP fastboot, an additional config is added so that the network can be initialized during fastboot initialization.
add an interface fastboot_handler. When nsh is not enabled, fastboot can be started directly through this interface.
add switchboot command.
Impact
For devices with strict boot time requirements, the network in bootloaders (BL) does not need to be initialized every time. It can be initialized when entering fastboot mode to save boot time. Therefore, a configuration similar to that for USB has been added to initialize the network during fastboot initialization.
Testing
PC: ubuntu 22.04.1
target: tricore device