Repository navigation
netutils/netlib: support delete the DNS server address by index or address - #3206
Conversation
cederom
left a comment
There was a problem hiding this comment.
Thank you @nuttxs :-) Some issues:
- Build errors, please fix.
- PR and Commit topic does not match content, it also changes DHCP functionalities, please update (i.e. netutils/netlib: DHCP and DNS related updates. then bullet point changes already there).
apache/nuttx#17284 need be merged first. |
|
Thanks @xiaoxiang781216 I missed the dependency on apache/nuttx#17284 sorry :-) @nuttxs please update git commit message to: |
|
@nuttxs could you please help to create some basic Documentation about netlib: https://nuttx.apache.org/docs/latest/applications/netutils/netlib/index.html ? |
|
The basic documentation update for “netlib” has been completed—please verify it (https://github.com/apache/nuttx/pull/17284/files#diff-a3d43ff48c0c7f39a7306020ac95d948edde9aebb9a3d30cdd13fcdff2d0b206) meets the requirements. |
cederom
left a comment
There was a problem hiding this comment.
Amazing work thank you @nuttxs :-)
NOTE: This PR depends on apache/nuttx#17284 and should be verified again after dependency merge :-)
6efaf9d to
769fd82
Compare
|
@nuttxs please fix the compiler error: |
2d05d60
769fd82 to
2d05d60
Compare
2d05d60 to
f3746b2
Compare
…dress - Modify the DHCP-client data structure to support multiple DNS addresses - Enhance DHCP-option parsing to extract all DNS-server addresses - Set all received DNS-server addresses - fix some test case build error Signed-off-by: nuttxs <zhaoqing.zhang@sony.com>
f3746b2 to
0e5674c
Compare
|
@nuttxs hi, dhcpc doesn't compile now when |
@raiden00pl to resolve the current build issue. |
@nuttxs also, please add an #else warning "CONFIG_NETDB_DNSCLIENT and CONFIG_LIBC_NETDB not define, DNS support is missing" |
Thank you for your valuable suggestions to improve the fix. |
Summary
netlib/netlib_delipv4dnsaddr.c: add DNS deletion functionality, support deleting DNS servers by address or by index:
Modify the DHCP-client data structure to support multiple DNS addresses.
Enhance DHCP-option parsing to extract all DNS-server addresses.
Set all received DNS-server addresses.
Fix some example case compiler error.
Depend on PR#apache/nuttx#17284
Impact
New Feature/Change: Yes
User Impact: support delete the DNS server address by index or address
Build Impact:No new Kconfig options or build system changes.
Hardware Impact: No
Security: No
Compatibility: Backward-compatible; no breaking changes.
Testing
Test process example