Skip to content

CDI: improve PackagingFilter performance by avoiding costly opeation in loop#9381

Open
NicolaIsotta wants to merge 1 commit intoapache:masterfrom
NicolaIsotta:packagingfilter-perf
Open

CDI: improve PackagingFilter performance by avoiding costly opeation in loop#9381
NicolaIsotta wants to merge 1 commit intoapache:masterfrom
NicolaIsotta:packagingfilter-perf

Conversation

@NicolaIsotta
Copy link
Copy Markdown
Contributor

Discovered this bottleneck while working on other things.
The current version recreates the ClasspathInfo every iteration of the loop, causing a remarkable slowdown; this PR introduces a lazily-inizialized resusable ClasspathInfo.
In one of my test cases (@Inject on a java.util.Map), the boost was ≃ 10x (time spent in the method went down from 2 secs to less than 200 millis).


^Add meaningful description above

Click to collapse/expand PR instructions

By opening a pull request you confirm that, unless explicitly stated otherwise, the changes -

  • are all your own work, and you have the right to contribute them.
  • are contributed solely under the terms and conditions of the Apache License 2.0 (see section 5 of the license for more information).

Please make sure (eg. git log) that all commits have a valid name and email address for you in the Author field.

If you're a first time contributor, see the Contributing guidelines for more information.

If you're a committer, please label the PR before pressing "Create pull request" so that the right test jobs can run.

PR approval and merge checklist:

  1. Was this PR correctly labeled, did the right tests run? When did they run?
  2. Is this PR squashed?
  3. Are author name / email address correct? Are co-authors correctly listed? Do the commit messages need updates?
  4. Does the PR title and description still fit after the Nth iteration? Is the description sufficient to appear in the release notes?

If this PR targets the delivery branch: don't merge. (full wiki article)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant