KAFKA-19755 Move KRaftClusterTest from core module to server module [4/4] #21230
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
triage
chia7712
reviewed
Jan 2, 2026
| } | ||
|
|
||
| // for testing | ||
| private[server] def updateCurrentConfig(props: util.Map[_, _]): Unit = { |
Member
There was a problem hiding this comment.
What is the usage of this method?
Collaborator
Author
There was a problem hiding this comment.
It's used to prevent direct references to KafkaConfig in KRaftClusterTest.
chia7712
reviewed
Jan 6, 2026
| controller.shutdown(); | ||
| // Rewrite The `listeners` config to avoid controller socket server init using different port | ||
| var config = controller.sharedServer().controllerConfig().props(); | ||
| ((java.util.HashMap<String, String>) config).put(SocketServerConfigs.LISTENERS_CONFIG, |
| p.toString().substring(log.dir().toString().length())); | ||
| if (!p.toString().equals(log.dir().toString())) { | ||
| try { | ||
| Files.copy(p, out); |
Member
There was a problem hiding this comment.
assertDoesNotThrow(() -> Files.copy(p, out));| .orElseThrow(); | ||
| var targetDirFile = new File(targetParentDir, log.dir().getName()); | ||
| targetDirFile.mkdir(); | ||
| Files.walk(Paths.get(log.dir().toString())).forEach(p -> { |
Member
There was a problem hiding this comment.
The Stream returned by Files.walk needs to be closed
| var controller = cluster.controllers().values().iterator().next(); | ||
| controller.controller().waitForReadyBrokers(3).get(); | ||
| TestUtils.retryOnExceptionWithTimeout(60000, () -> { | ||
| var latch = QuorumControllerIntegrationTestUtils.pause((QuorumController) controller.controller()); |
Member
There was a problem hiding this comment.
I'm not a fan of adding an entire dependency for such a minor reference. Maybe we can duplicate a bit of code as a trade-off?
Collaborator
Author
There was a problem hiding this comment.
That's a fair point. I actually considered duplicating the code as well, but it leads to two issues:
- We would need to change the visibility of
QuorumController#appendControlEventto public. - We would still need to reference
QuorumController, which means the dependency is unavoidable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move KRaftClusterTest from core module to server module.
Rewrite