Skip to content

Conversation

@dhruvildave235
Copy link

What changed

Improved the consumer rebalance warning log by logging the full exception object instead of only the message.

Why

This improves observability and makes it easier to diagnose rebalance-related issues in production environments.

Testing

./gradlew :clients:compileJava

Copilot AI review requested due to automatic review settings December 29, 2025 10:02
@github-actions github-actions bot added triage PRs from the community consumer clients small Small PRs labels Dec 29, 2025
@dhruvildave235
Copy link
Author

Thanks for the review!
The change is ready and CI has been validated locally.
Happy to address any feedback.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR improves observability in consumer rebalance error handling by logging the full exception object instead of just the exception message. This enables stack traces to be captured in logs, making it easier to diagnose rebalance-related issues in production environments.

Key changes:

  • Modified the log.warn() call in ConsumerMembershipManager.consumerRebalanceListenerCallbackCompleted() to pass the exception object as the last parameter instead of e.getMessage()
  • Updated the log message text from a more verbose description to a more concise format

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@dhruvildave235
Copy link
Author

Thanks for the review.

I’ve fixed the indentation and updated the log message to follow Kafka’s positional placeholder style. The exception object is now passed to preserve stack traces.

Please let me know if anything else is needed.

@github-actions github-actions bot removed the triage PRs from the community label Dec 30, 2025
@dhruvildave235
Copy link
Author

Hi maintainers, just a gentle ping on this PR.
All CI checks have passed and the PR has CI approval.
Please let me know if any further changes are needed from my side.
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants