Skip to content

MINOR: Use TransactionOperation enum instead of String for pending state checks #21218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chia7712 merged 1 commit into from
Jan 3, 2026
+23 −5
Merged

MINOR: Use TransactionOperation enum instead of String for pending state checks #21218

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 23 additions & 5 deletions clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,6 +205,24 @@ private enum Priority {
this.priority = priority;
}
}

private enum TransactionOperation {
SEND("send"),
BEGIN_TRANSACTION("beginTransaction"),
PREPARE_TRANSACTION("prepareTransaction"),
SEND_OFFSETS_TO_TRANSACTION("sendOffsetsToTransaction");

final String displayName;

TransactionOperation(String displayName) {
this.displayName = displayName;
}

@Override
public String toString() {
return displayName;
}
}

public TransactionManager(final LogContext logContext,
final String transactionalId,
Expand Down Expand Up @@ -331,7 +349,7 @@ synchronized TransactionalRequestResult initializeTransactions(

public synchronized void beginTransaction() {
ensureTransactional();
throwIfPendingState("beginTransaction");
throwIfPendingState(TransactionOperation.BEGIN_TRANSACTION);
maybeFailWithError();
transitionTo(State.IN_TRANSACTION);
}
Expand All @@ -343,7 +361,7 @@ public synchronized void beginTransaction() {
*/
public synchronized void prepareTransaction() {
ensureTransactional();
throwIfPendingState("prepareTransaction");
throwIfPendingState(TransactionOperation.PREPARE_TRANSACTION);
maybeFailWithError();
transitionTo(State.PREPARED_TRANSACTION);
this.preparedTxnState = new ProducerIdAndEpoch(
Expand Down Expand Up @@ -406,7 +424,7 @@ private TransactionalRequestResult beginCompletingTransaction(TransactionResult
public synchronized TransactionalRequestResult sendOffsetsToTransaction(final Map<TopicPartition, OffsetAndMetadata> offsets,
final ConsumerGroupMetadata groupMetadata) {
ensureTransactional();
throwIfPendingState("sendOffsetsToTransaction");
throwIfPendingState(TransactionOperation.SEND_OFFSETS_TO_TRANSACTION);
maybeFailWithError();

if (currentState != State.IN_TRANSACTION) {
Expand Down Expand Up @@ -438,7 +456,7 @@ public synchronized TransactionalRequestResult sendOffsetsToTransaction(final Ma

public synchronized void maybeAddPartition(TopicPartition topicPartition) {
maybeFailWithError();
throwIfPendingState("send");
throwIfPendingState(TransactionOperation.SEND);

if (isTransactional()) {
if (!hasProducerId()) {
Expand Down Expand Up @@ -1248,7 +1266,7 @@ private TxnOffsetCommitHandler txnOffsetCommitHandler(TransactionalRequestResult
return new TxnOffsetCommitHandler(result, builder);
}

private void throwIfPendingState(String operation) {
private void throwIfPendingState(TransactionOperation operation) {
if (pendingTransition != null) {
if (pendingTransition.result.isAcked()) {
pendingTransition = null;
Expand Down