-
Notifications
You must be signed in to change notification settings - Fork 14.9k
KAFKA-18053 Clean up topology config #19995
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: trunk
Are you sure you want to change the base?
KAFKA-18053 Clean up topology config #19995
Conversation
@mjsax The KIP is voted since june: https://lists.apache.org/[email protected]:2025-6:KIP-1138 |
|
Ah. Never mind than. -- Please update the status to "accepted" :) Thanks. |
|
This PR is being marked as stale since it has not had any activity in 90 days. If you If you are having difficulty finding a reviewer, please reach out on the [mailing list](https://kafka.apache.org/contact). If this PR is no longer valid or desired, please feel free to close it. If no activity occurs in the next 30 days, it will be automatically closed. |
|
This PR has been closed since it has not had any activity in 120 days. If you feel like this |
|
A label of 'needs-attention' was automatically added to this PR in order to raise the |
first commit # Conflicts: # streams/src/test/java/org/apache/kafka/streams/processor/internals/StreamTaskTest.java # streams/src/test/java/org/apache/kafka/streams/processor/internals/TaskManagerTest.java
Fix comments
d9c15f3 to
9f30ee4
Compare
Pull request to implement KIP-1138, which aims to address several issues related to the configuration application process in Kafka Streams.
This PR has multiple goals:
Deprecate
TopologyConfigin favor ofStreamsConfig.Deprecate
StreamsBuilder#build(StreamsConfig)and encourage users to pass configurations via theStreamsBuilderconstructor instead.Deprecate constructors in
StreamsBuilderand Topology that accept aTopologyConfig, replacing them with constructors that accept a Properties or Map.Improve misconfiguration detection by:
StreamsConfigbut not applied to the topology.