Skip to content

Conversation

@sebastienviale
Copy link
Contributor

@sebastienviale sebastienviale commented Jun 19, 2025

Pull request to implement KIP-1138, which aims to address several issues related to the configuration application process in Kafka Streams.

This PR has multiple goals:

  • Deprecate TopologyConfig in favor of StreamsConfig.

  • Deprecate StreamsBuilder#build(StreamsConfig) and encourage users to pass configurations via the StreamsBuilder constructor instead.

  • Deprecate constructors in StreamsBuilder and Topology that accept a TopologyConfig, replacing them with constructors that accept a Properties or Map.

  • Improve misconfiguration detection by:

    • Throwing an exception if a topology-specific config is set in StreamsConfig but not applied to the topology.
    • Logging a warning if a topology-specific config is set in both places but has different values.

@sebastienviale sebastienviale marked this pull request as draft June 19, 2025 06:32
@github-actions github-actions bot added triage PRs from the community streams and removed triage PRs from the community labels Jun 19, 2025
@sebastienviale sebastienviale marked this pull request as ready for review June 24, 2025 06:37
@mjsax mjsax added the kip Requires or implements a KIP label Aug 27, 2025
@mjsax
Copy link
Member

mjsax commented Aug 27, 2025

@sebastienviale
Copy link
Contributor Author

@mjsax
Copy link
Member

mjsax commented Sep 2, 2025

Ah. Never mind than. -- Please update the status to "accepted" :) Thanks.

@github-actions
Copy link

github-actions bot commented Dec 2, 2025

This PR is being marked as stale since it has not had any activity in 90 days. If you
would like to keep this PR alive, please leave a comment asking for a review. If the PR has
merge conflicts, update it with the latest from the base branch.

If you are having difficulty finding a reviewer, please reach out on the [mailing list](https://kafka.apache.org/contact).

If this PR is no longer valid or desired, please feel free to close it. If no activity occurs in the next 30 days, it will be automatically closed.

@github-actions github-actions bot added the stale Stale PRs label Dec 2, 2025
@github-actions
Copy link

github-actions bot commented Jan 1, 2026

This PR has been closed since it has not had any activity in 120 days. If you feel like this
was a mistake, or you would like to continue working on it, please feel free to re-open the
PR and ask for a review.

@github-actions github-actions bot added the closed-stale PRs that were closed due to inactivity label Jan 1, 2026
@github-actions github-actions bot closed this Jan 1, 2026
@mjsax mjsax reopened this Jan 8, 2026
@github-actions github-actions bot added the triage PRs from the community label Jan 8, 2026
@github-actions
Copy link

github-actions bot commented Jan 9, 2026

A label of 'needs-attention' was automatically added to this PR in order to raise the
attention of the committers. Once this issue has been triaged, the triage label
should be removed to prevent this automation from happening again.

@github-actions github-actions bot added needs-attention and removed closed-stale PRs that were closed due to inactivity stale Stale PRs labels Jan 9, 2026
first commit

# Conflicts:
#	streams/src/test/java/org/apache/kafka/streams/processor/internals/StreamTaskTest.java
#	streams/src/test/java/org/apache/kafka/streams/processor/internals/TaskManagerTest.java
@sebastienviale sebastienviale force-pushed the KAFKA-18053-Clean-Up-TopologyConfig branch from d9c15f3 to 9f30ee4 Compare January 9, 2026 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kip Requires or implements a KIP needs-attention streams triage PRs from the community

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants