Core, Flink: Add UUID to DataTestBase SUPPORTED_PRIMITIVES#16364
Merged
Conversation
Co-authored-by: Joy Haldar <joy.haldar@target.com>
Contributor
Author
|
cc: @pvary, @Guosmilesmile, @mxm As we discussed on #16097, this adds |
pvary
approved these changes
May 18, 2026
Contributor
|
Merged to main. |
mxm
reviewed
May 21, 2026
Contributor
mxm
left a comment
mxm
left a comment
There was a problem hiding this comment.
Thank you @joyhaldar for following up and extending the test coverage!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #16097.
Adds a UUID field to
SUPPORTED_PRIMITIVESin DataTestBase.UUIDwas only tested in Flink's TestFlinkUuidType before. Now every test that extendsDataTestBasereads and writesUUIDtoo.TestFlinkParquetReader extends
DataTestBaseand has a test with a Parquet schema written out by hand to matchSUPPORTED_PRIMITIVES. Updated that schema to add theUUIDcolumn, for Flink2.1,2.0and1.20.