HADOOP-19472: [ABFS] Remove write aggressiveness optimization #8141
Conversation
============================================================
|
|
💔 -1 overall
This message was automatically generated. |
There was a problem hiding this comment.
I know this is not a part of change here but since we are doing code cleanup here, I feel we should keep these constants in some constant file only like InternalConstants or MetricsConstants.
This file mainly contains constants used in configuration.
Starting from ZERO to SCALE_DIRECTION_NO_ACTION_NEEDED
| * Number of bytes in a gigabyte. | ||
| */ | ||
| public static final long BYTES_PER_GIGABYTE = 1024L * 1024 * 1024; | ||
| /** |
There was a problem hiding this comment.
There are a few constants in AbfsHttpConstants file that also need to be removed.
| @@ -1,107 +0,0 @@ | |||
| /** | |||
There was a problem hiding this comment.
Sine there is only one resource utilization metric left. Do we need the base class?
Can we simply have one stand alone class called ResourceUtilizationMetrics instead of saying read/write?
Also anyway we are monitoring JVM resources here, so single metric is sufficient IMO.
There was a problem hiding this comment.
I created this design to be generic such that in future if we want to add metrics for any other operation that can be done in a separate class as the update method takes stats specific to a particular operation.
|
💔 -1 overall
This message was automatically generated. |
============================================================
|
… HADOOP-19472_fix
|
💔 -1 overall
This message was automatically generated. |
4 participants
Removing write aggressiveness code and related metrics from trunk