Repository navigation
Conversation
This was referenced Oct 21, 2026
Open
Open
[#14049] improvement(test): Replace the remaining container CLI calls with in-process clients
#14076
Draft
Open
Open
Open
Draft
Draft
Draft
nevzheng
force-pushed
the
claude/13900-tc-00c-backend-autoclose
branch
7 times, most recently
from
October 21, 2026 19:28
a7d55cf to
7ce74f5
Compare
nevzheng
force-pushed
the
claude/13900-tc-00c-backend-autoclose
branch
3 times, most recently
from
October 21, 2026 19:44
2422b13 to
326398b
Compare
nevzheng
force-pushed
the
claude/13900-tc-00c-backend-autoclose
branch
2 times, most recently
from
October 21, 2026 21:16
dadc90f to
c4eb059
Compare
nevzheng
force-pushed
the
claude/13900-tc-00c-backend-autoclose
branch
from
October 21, 2026 21:18
c4eb059 to
c2d1f8f
Compare
nevzheng
changed the title
nevzheng
force-pushed
the
claude/13900-tc-00c-backend-autoclose
branch
from
October 21, 2026 21:37
c2d1f8f to
c248c7c
Compare
nevzheng
force-pushed
the
claude/13900-tc-00c-backend-autoclose
branch
4 times, most recently
from
October 22, 2026 03:28
b003887 to
03c1b1c
Compare
…st libraries each module uses
…s built-in store cleanup
nevzheng
force-pushed
the
claude/13900-tc-00c-backend-autoclose
branch
from
October 22, 2026 04:29
03c1b1c to
34d493e
Compare
nevzheng
marked this pull request as ready for review
October 22, 2026 12:16
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
BackendTestExtensionkeeps its per-class backend in the JUnit extension store as anAutoCloseablevalue, so JUnit closes it; the hand-written after-all cleanup goes away.Why are the changes needed?
JUnit 6's store closes
AutoCloseablevalues with the context that owns them. Keeping the backend there removes the hand-written after-all cleanup, and the extension closes resources the same way the container fixtures in the framework PRs do.Fix: #14105
Does this PR introduce any user-facing change?
No. Test code only.
How was this patch tested?
At the top of S0 (this PR, which carries #14103, #14083 and #14084):
./gradlew build -PskipITs -PskipDockerTests=false -PskipWeb=truewith CI's excludes: spotless, checkstyle and compile clean; 10,711 unit tests, 65 skipped, one known-flaky TLS test that passes on rerun.:core:coreH2Test,:core:coreMySQLTest,:core:corePostgreSQLTest: 594 tests each, all pass.:<module>:test -PskipDockerTests=false) pass for integration-test-common, catalog-jdbc-common, -mysql and -postgresql, catalog-hive, flink-common, catalog-kafka and OceanBase; the only failures (ClickHouse vector index,testCheckJDBCDriver) also fail onmainand are fixed in [#14095] fix(test): Default to the CI ClickHouse image so the vector-index tests pass locally #14097 and [#14095] fix(test): Fix the order-dependent NPE in testCheckJDBCDriver #14099.Stack: #14103 → #14083 → #14084 → #14085 → #14005 → #14006 → #14052 → #14076 → #14007 → #14008 → #14009 → #14010 → #14011 → #14012 → #14013 → #14079 → #14077 → #14078 → #14086 → #14087 → #14088 → #14089 → #14090 → #14091 → #14094