Repository navigation
fix(a11y): add a skip link, and move focus to the content on a change of page - #824
Open
opensource-joe wants to merge 3 commits into
Open
opensource-joe wants to merge 3 commits into
opensource-joe wants to merge 3 commits into
Conversation
Every authenticated page puts the header and the whole sidebar, over a hundred links, ahead of the content in the tab order: 105 Tab presses on /clients at 1440x900. Add a "Skip to main content" link as the first stop, off screen until it takes focus, and make <main> its target with id="main-content" and tabindex="-1". The link handles its own click. With <base href="/">, a bare #main-content resolves to /#main-content, so a plain anchor would leave the page. Giving main an id changes the selector axe reports for the existing scrollable-region-focusable entry in the shell baseline, so the key moves from main to #main-content. The finding itself is unchanged. Refs apache#746
After picking a sidebar link, focus stayed on that link, or dropped to the top of the document when the control that had it was destroyed. Either way the next Tab went back through the navigation. Move focus to main when the path changes. Leave it alone on the first navigation, so a fresh load still starts at the skip link; when only the query string changes, so a paginator or filter keeps its focus; and when focus is already inside main, such as a page focusing its own heading. Closes apache#746
Contributor
Author
|
The two real-Fineract E2E shards that failed here fail the same way on Generated by Claude Code |
Contributor
E2E — mocked backend🎭 E2E Tests✅ All green — 429 passed · 0 failed · 1 skipped, across 41 spec files in 9m 35s. By spec file
All 430 tests — click to expand
Slowest 10 — what the shard counts should be tuned against
📼 Download the HTML report, videos and traces — see the Generated by run 39435169256 from |
Contributor
E2E — real Fineract🎭 E2E Tests❌ 2 failing — 162 passed · 2 failed · 7 skipped · 6 flaky, across 50 spec files in 12m 38s. ❌ Failures
|
| Spec | ✅ | ❌ | ⏭️ | 🔒 | Time |
|---|---|---|---|---|---|
| backend.setup.ts | 3 | 0 | 0 | 0 | 6.6s |
| accounting-closure-backend.spec.ts | 2 | 0 | 0 | 0 | 14.9s |
| batch-api-operations.spec.ts | 5 | 0 | 0 | 0 | 34.1s |
| center-servicing.spec.ts | 2 | 0 | 0 | 0 | 19.4s |
| charge-servicing-backend.spec.ts | 6 | 0 | 0 | 0 | 33.0s |
| client-legal-form-search.spec.ts | 1 | 0 | 0 | 0 | 5.4s |
| client-transfer.spec.ts | 4 | 0 | 0 | 0 | 50.7s |
| collection-sheet.spec.ts | 1 | 0 | 0 | 0 | 7.3s |
| deposit-account-servicing.spec.ts | 3 | 0 | 0 | 0 | 29.2s |
| deposit-lifecycle-backend.spec.ts | 4 | 0 | 0 | 0 | 27.3s |
| deposit-product-configuration.spec.ts | 3 | 0 | 0 | 0 | 20.3s |
| double-submit-backend.spec.ts | 2 | 0 | 0 | 0 | 14.2s |
| form-layout-reflow.spec.ts | 6 | 0 | 0 | 0 | 39.8s |
| group-membership.spec.ts | 3 | 0 | 0 | 0 | 53.5s |
| loan-account-actions.spec.ts | 3 | 0 | 0 | 0 | 27.6s |
| loan-approved-amount-revision.spec.ts | 3 | 0 | 0 | 0 | 23.2s |
| loan-charge-off.spec.ts | 2 | 0 | 0 | 0 | 23.4s |
| loan-flows-non-admin-roles.spec.ts | 2 | 1 | 5 | 0 | 1m 21s |
| loan-product-accounting.spec.ts | 1 | 0 | 0 | 0 | 33.3s |
| loan-repayment-gating.spec.ts | 2 | 0 | 0 | 0 | 9.8s |
| loan-servicing-rbac-backend.spec.ts | 4 | 0 | 0 | 0 | 11.2s |
| loan-servicing.spec.ts | 2 | 0 | 0 | 0 | 19.9s |
| login.spec.ts | 4 | 0 | 0 | 0 | 5.5s |
| oidc-login-backend.spec.ts | 2 | 0 | 0 | 0 | 5.2s |
| parity-screens.spec.ts | 8 | 0 | 0 | 0 | 47.6s |
| rbac-backend-restricted-user.spec.ts | 7 | 0 | 0 | 0 | 36.3s |
| rbac-dead-end-controls.spec.ts | 7 | 0 | 0 | 0 | 35.6s |
| rbac-disabled-flag-backend.spec.ts | 6 | 0 | 0 | 0 | 28.6s |
| rbac-multi-permission.spec.ts | 9 | 0 | 0 | 0 | 59.6s |
| rbac-office-scoped-user.spec.ts | 6 | 0 | 0 | 0 | 27.1s |
| bulk-import-entity-types.spec.ts | 1 | 0 | 0 | 0 | 9.5s |
| delinquency-configuration.spec.ts | 2 | 0 | 0 | 0 | 19.0s |
| full-demo.spec.ts | 1 | 0 | 0 | 0 | 59.5s |
| interest-rate-charts.spec.ts | 1 | 0 | 0 | 0 | 8.3s |
| loan-lifecycle.spec.ts | 4 | 0 | 0 | 0 | 2m 2s |
| loan-schedule-type.spec.ts | 3 | 0 | 0 | 0 | 34.3s |
| rbac-permissionless-user.spec.ts | 4 | 0 | 0 | 0 | 23.8s |
| report-mailing-job.spec.ts | 3 | 0 | 0 | 0 | 21.2s |
| report-parameter-backend.spec.ts | 4 | 0 | 0 | 0 | 24.2s |
| savings-flows-non-admin-roles.spec.ts | 7 | 0 | 0 | 0 | 1m 44s |
| savings-transaction-correction.spec.ts | 1 | 0 | 0 | 0 | 7.0s |
| savings-transaction-gating.spec.ts | 2 | 0 | 0 | 0 | 6.8s |
| share-account-servicing.spec.ts | 2 | 0 | 0 | 0 | 18.7s |
| share-product-accounting.spec.ts | 1 | 0 | 0 | 0 | 28.2s |
| teller-cash-management.spec.ts | 2 | 0 | 0 | 0 | 41.9s |
| tenant-date-defaults-backend.spec.ts | 1 | 0 | 0 | 0 | 7.5s |
| working-capital-loan-actions-backend.spec.ts | 3 | 0 | 0 | 0 | 24.8s |
| working-capital-product-accounting-backend.spec.ts | 2 | 0 | 0 | 0 | 23.4s |
| working-capital-rbac-backend.spec.ts | 2 | 0 | 0 | 0 | 8.0s |
| working-capital-servicing-backend.spec.ts | 3 | 1 | 2 | 0 | 18.8s |
All 171 tests — click to expand
backend.setup.ts
- ✅ seed backend reference data —
2.2s - ✅ seed backend reference data —
2.1s - ✅ seed backend reference data —
2.3s
accounting-closure-backend.spec.ts
- ✅ Accounting closures against Fineract › a closed period reads as Closed, and the platform refuses a posting inside it —
8.2s - ✅ Accounting closures against Fineract › the form keeps the user on the page and names the reason when Fineract refuses —
6.7s
batch-api-operations.spec.ts
- ✅ Batch API Operations against Fineract › runs the sample batch scenario — create client, create loan, add and read back a charge —
6.3s - ✅ Batch API Operations against Fineract › shows a parse error instead of submitting when the batch input is not valid JSON —
7.1s - ✅ Batch API enclosingTransaction semantics against Fineract › rolls back the earlier steps when enclosingTransaction is true and a later step fails —
9.0s(retried 1×) - ✅ Batch API enclosingTransaction semantics against Fineract › does not roll back the earlier steps when enclosingTransaction is false and a later step fails —
6.1s - ✅ Batch API Operations on a mobile viewport against Fineract › the sample batch scenario is reachable and works by touch at mobile width —
5.7s
center-servicing.spec.ts
- ✅ Center servicing › a center is activated, staffed and given a group —
13.4s - ✅ Center servicing › notes are recorded against the center —
6.0s
charge-servicing-backend.spec.ts
- ✅ loan charge servicing › waives a loan charge, and the platform records the waiver —
6.8s - ✅ loan charge servicing › cannot reverse a waiver: the platform answers 500, not a business rule —
610ms - ✅ loan charge servicing › offers no Pay on a charge the platform will not let be paid —
5.6s - ✅ loan charge servicing › adjusts a loan charge to a smaller amount —
7.2s - ✅ savings charge servicing › pays a savings charge with the amount and due date the platform demands —
6.6s - ✅ savings charge servicing › carries an active flag, which is what gates Inactivate —
6.3s
client-legal-form-search.spec.ts
- ✅ Client list: legal form filtering › an entity client appears in the main client list —
5.4s
client-transfer.spec.ts
- ✅ Client transfer between offices › a proposed transfer is held until the destination accepts, and then the client moves —
12.9s - ✅ Client transfer between offices › a rejected transfer leaves the client on hold, and withdrawing is the way back —
13.5s - ✅ Client transfer between offices › a client can be transferred in one step when the user may act for both offices —
11.3s - ✅ Client staff assignment › an officer can be assigned and then removed —
13.0s
collection-sheet.spec.ts
- ✅ Collection Sheet › scopes staff to the office, sends the choice, and reports an empty sheet —
7.3s
deposit-account-servicing.spec.ts
- ✅ Term deposit account servicing › an account is approved, activated and closed before maturity —
12.6s - ✅ Term deposit account servicing › a deposit is recorded, listed, and reversed without leaving the list —
10.1s - ✅ Term deposit account servicing › an application can be rejected instead of approved —
6.5s
deposit-lifecycle-backend.spec.ts
- ✅ fixed deposit products › carry the rate the user typed, not a hidden default —
6.3s - ✅ an active fixed deposit account › shows its balance and maturity figures —
5.7s - ✅ an active fixed deposit account › can be closed into the client savings account —
8.5s - ✅ an active fixed deposit account › can have a charge added to it —
6.8s
deposit-product-configuration.spec.ts
- ✅ Deposit product configuration › a fixed deposit product survives being edited —
7.0s - ✅ Deposit product configuration › a recurring deposit product can be created at all —
5.9s - ✅ Deposit product configuration › a savings product carries its accounting configuration —
7.4s
double-submit-backend.spec.ts
- ✅ A double-click submits once › a repayment is recorded once, not twice —
6.4s - ✅ A double-click submits once › a client is created once, not twice —
7.8s
form-layout-reflow.spec.ts
- ✅ form layout at the narrow viewport › Create GL Account gives every field a usable width at 320px —
6.1s - ✅ form layout at the narrow viewport › Create Loan gives every field a usable width at 320px —
5.6s - ✅ form layout at the narrow viewport › Create Office gives every field a usable width at 320px —
5.6s - ✅ form layout at the narrow viewport › Create Staff gives every field a usable width at 320px —
5.6s - ✅ form layout at the narrow viewport › no page-level horizontal scroll at 320px —
10.9s - ✅ form layout at the wide viewport › Create GL Account still uses more than one column at 1280px —
6.1s
group-membership.spec.ts
- ✅ Group membership and lifecycle › a group is activated, staffed, given members and a committee, then emptied —
22.6s - ✅ Group membership and lifecycle › notes are recorded against the group and can be removed again —
10.3s - ✅ Group membership and lifecycle › an empty group is closed with a reason, and a group with members is refused —
20.7s
loan-account-actions.spec.ts
- ✅ Loan account lifecycle actions › new action menu items appear only for active loans —
8.2s - ✅ Loan account lifecycle actions › undo disbursal shows a confirm dialog and reverts the loan to Approved —
10.0s - ✅ Loan account lifecycle actions › write off requires confirmation and moves the loan out of Active status —
9.4s
loan-approved-amount-revision.spec.ts
- ✅ Loan approved and available-disbursement amount revision › revises the approved amount on an active, partially-disbursed loan —
8.0s - ✅ Loan approved and available-disbursement amount revision › revises the available disbursement amount, which also changes the approved amount —
8.1s - ✅ Loan approved and available-disbursement amount revision › shows the platform’s own refusal, not a generic validation message —
7.1s
loan-charge-off.spec.ts
- ✅ Loan servicing commands › charges a loan off through the UI and reverses it —
12.5s - ✅ Loan servicing commands › records a goodwill credit through the shared transaction form —
10.9s
loan-flows-non-admin-roles.spec.ts
- ✅ a loan taken through four separated duties, every account built in the UI › an administrator builds the four roles and accounts through the forms —
39.4s(retried 2×) - ✅ a loan taken through four separated duties, every account built in the UI › the officer books the application and is not offered approval of their own loan —
15.1s(retried 2×) - ❌ a loan taken through four separated duties, every account built in the UI › the approver, differing from the officer in one code, is offered it and approves —
26.4s(retried 2×) - ⏭️ a loan taken through four separated duties, every account built in the UI › the approver is not offered disbursement of the loan they just approved —
0ms(retried 2×) - ⏭️ a loan taken through four separated duties, every account built in the UI › the disburser, holding only DISBURSE_LOAN, completes the payout end to end —
0ms(retried 2×) - ⏭️ a loan taken through four separated duties, every account built in the UI › and the same route now refuses an UPDATE_LOAN holder, as the platform does —
0ms(retried 2×) - ⏭️ a loan taken through four separated duties, every account built in the UI › a command with no mapped code is left to the platform rather than guessed at —
0ms(retried 2×) - ⏭️ a loan taken through four separated duties, every account built in the UI › a repayment duty reaches its own form, and records a repayment —
0ms(retried 2×)
loan-product-accounting.spec.ts
- ✅ Loan product accounting › a cash-accounting product is configured, round-trips on edit, and posts to the ledger —
33.3s
loan-repayment-gating.spec.ts
- ✅ Repayment is offered only where the platform allows it › withheld on a loan awaiting approval, offered once it is active —
9.4s - ✅ Repayment is offered only where the platform allows it › the platform refuses a repayment on a loan awaiting approval —
355ms
loan-servicing-rbac-backend.spec.ts
- ✅ loan servicing and charge command permissions, on the platform › each command is authorised by the code the UI declares for it —
5.3s - ✅ loan servicing and charge command permissions, on the platform › no portfolio write code authorises any of its entity commands —
5.6s - ✅ loan servicing and charge command permissions, on the platform › the deferred-income adjustments are not commands at loan level —
156ms - ✅ loan servicing and charge command permissions, on the platform › the deferred-income adjustments are commands on one transaction —
137ms
loan-servicing.spec.ts
- ✅ Loan servicing: notes and transaction adjustment › notes can be added and removed, with a confirm dialog on delete —
9.3s - ✅ Loan servicing: notes and transaction adjustment › a repayment transaction can be viewed and adjusted with a corrected amount —
10.6s
login.spec.ts
- ✅ Login › login page displays correctly —
1.2s - ✅ Login › login form has required fields —
1.7s - ✅ Login › submit button is disabled when form is empty —
1.4s - ✅ Login › submit button is enabled when form is filled —
1.3s
oidc-login-backend.spec.ts
- ✅ identity-provider route against a real Fineract › is offered beside the password form, and pressing it sends nothing to Fineract —
1.8s - ✅ identity-provider route against a real Fineract › a real password sign-in still gets a session with the route offered —
3.4s
parity-screens.spec.ts
- ✅ Screens added for platform parity › a manual journal entry can be read whole and reversed —
6.6s - ✅ Screens added for platform parity › an entry that is already reversed is not offered again —
5.4s - ✅ Screens added for platform parity › a report definition can be created, edited and deleted; a core one cannot —
5.9s - ✅ Screens added for platform parity › a core report opens read-only with only its in-use setting —
4.6s - ✅ Screens added for platform parity › a pending loan is approved from the queue, in a batch —
6.8s - ✅ Screens added for platform parity › a fixed deposit is listed as a deposit, not as a savings account —
5.2s - ✅ Screens added for platform parity › an office has a screen, and it carries its custom fields —
5.3s - ✅ Screens added for platform parity › a savings account carries notes, and the note survives a reload —
7.9s
rbac-backend-restricted-user.spec.ts
- ✅ a genuinely restricted Fineract user › holds exactly the permissions their role was granted —
196ms - ✅ a genuinely restricted Fineract user › reaches the screen their permission covers —
5.5s - ✅ a genuinely restricted Fineract user › is refused a screen their permission does not cover, by URL and by the backend —
5.0s - ✅ a genuinely restricted Fineract user › is refused a write screen they can read the list for, and the write itself —
6.4s - ✅ a genuinely restricted Fineract user › is not offered the actions it would be refused for —
4.8s - ✅ a genuinely restricted Fineract user › is shown an action it cannot take, disabled and saying what it needs —
5.4s - ✅ a genuinely restricted Fineract user › the superuser the rest of the suite uses is unaffected —
9.1s
rbac-dead-end-controls.spec.ts
- ✅ a client's account tables › withhold the link, but not the number, from a user who cannot open the account —
5.2s - ✅ a client's account tables › keep the link for a user who holds READ_LOAN —
5.3s - ✅ the office transactions list › withholds Create from a reader, and the route refuses it too —
6.4s - ✅ the office transactions list › offers Create to an administrator —
4.4s - ✅ the office transactions list › refuses the list at the door for the code the platform does not check —
4.3s - ✅ a group's member list › names the member without linking when the reader cannot open clients —
4.5s - ✅ a group's member list › keeps the link for a reader who holds READ_CLIENT —
5.6s
rbac-disabled-flag-backend.spec.ts
- ✅ rbacEnabled: false, with a user who holds only READ_CLIENT › is shown the whole navigation, including modules their role does not cover —
3.2s - ✅ rbacEnabled: false, with a user who holds only READ_CLIENT › is admitted by the route guard to a screen their role does not cover —
8.1s - ✅ rbacEnabled: false, with a user who holds only READ_CLIENT › is still refused by Fineract, which the flag does not reach —
609ms - ✅ rbacEnabled: false, with a user who holds only READ_CLIENT › is told the list is beyond their role, and not offered a retry that cannot succeed —
5.3s - ✅ rbacEnabled: false, with a user who holds only READ_CLIENT › gets the same treatment on a second refused list, not a one-screen fix —
6.0s - ✅ rbacEnabled: false, with a user who holds only READ_CLIENT › still loads the list their role does cover, with no failure state at all —
5.5s
rbac-multi-permission.spec.ts
- ✅ a route declaring more than one permission code (OR semantics) › is admitted by either declared code alone —
5.1s - ✅ a route declaring more than one permission code (OR semantics) › is admitted by the other declared code alone —
4.5s - ✅ a route declaring more than one permission code (OR semantics) › is refused when holding neither declared code, by the router and by the backend —
5.7s - ✅ ALL_FUNCTIONS_READ, against the real Fineract permission catalogue › reaches read screens across modules it holds no specific code for —
9.6s - ✅ ALL_FUNCTIONS_READ, against the real Fineract permission catalogue › is refused every write screen, and the writes themselves —
7.7s - ✅ a restricted session across a real page reload › keeps the same permission boundary after reloading, not just after a fresh login —
10.7s - ✅ a second real action-level gate, distinct from loan repayment › is shown the Approve action disabled and naming what it needs, refused by the backend too —
5.7s - ✅ Security module writes (users, roles), against the real backend › reaches the list screens but is refused the write screens —
10.3s - ✅ Security module writes (users, roles), against the real backend › is refused creating a user and modifying a role, by the backend itself —
292ms
rbac-office-scoped-user.spec.ts
- ✅ an account scoped to a branch office › differs from a head-office account in office alone, not in permissions —
386ms - ✅ an account scoped to a branch office › is shown only its own office in the client list, and told which office it is in —
4.5s - ✅ an account scoped to a branch office › sees a shorter list than an identically-permissioned head-office account —
5.2s - ✅ an account scoped to a branch office › is refused another office’s client by the platform, and told so once —
5.3s - ✅ an account scoped to a branch office › can still open the record that is in its own office —
5.1s - ✅ an account scoped to a branch office › is not offered an edit it would be refused for on the Offices screen —
6.6s
bulk-import-entity-types.spec.ts
- ✅ every offered entity type is one the platform accepts —
9.5s
delinquency-configuration.spec.ts
- ✅ creates a delinquency range, then edits it —
10.1s - ✅ creates a delinquency bucket from the ranges the template offers —
8.9s
full-demo.spec.ts
- ✅ Full feature demo recording › walk through loan schedule type, lifecycle, custom fields, collateral, and disbursement —
59.5s
interest-rate-charts.spec.ts
- ✅ lists charts without a server error —
8.3s
loan-lifecycle.spec.ts
- ✅ Loan lifecycle: creation, approval, disbursement › create, approve, and disburse a Cumulative loan —
32.1s - ✅ Loan lifecycle: creation, approval, disbursement › create, approve, and disburse a Progressive loan —
32.0s - ✅ Loan lifecycle: creation, approval, disbursement › an approved loan can be returned to pending approval —
29.8s - ✅ Loan lifecycle: creation, approval, disbursement › the delinquency tab reads a real loan, and the empty data tabs stay hidden —
28.0s
loan-schedule-type.spec.ts
- ✅ Loan Schedule Type (Cumulative vs Progressive) › loan products list shows a schedule type chip per product —
9.1s - ✅ Loan Schedule Type (Cumulative vs Progressive) › create a Progressive loan product end-to-end and verify it round-trips —
15.1s - ✅ Loan Schedule Type (Cumulative vs Progressive) › loan creation shows the schedule type badge for a Progressive product —
10.0s
rbac-permissionless-user.spec.ts
- ✅ an account whose role grants nothing › is authenticated by Fineract and authorized by it for nothing —
811ms - ✅ an account whose role grants nothing › is signed in and landed on a screen rather than stranded at the login form —
5.4s - ✅ an account whose role grants nothing › is offered no permission-gated module, and refused each one by URL and by Fineract —
11.9s - ✅ an account whose role grants nothing › is left a navigation whose entries actually work —
5.6s
report-mailing-job.spec.ts
- ✅ report mailing job creation › is no longer refused for a missing parameter —
6.8s - ✅ report mailing job creation › the payload carries the locale and the schedule —
6.2s - ✅ report mailing job creation at the narrow viewport › every field is reachable and the job still saves at 320px —
8.3s
report-parameter-backend.spec.ts
- ✅ Dynamic report parameters against Fineract › keeps the parameter form available when a report has cascading lookups —
4.9s - ✅ Dynamic report parameters against Fineract › changing Office changes the Client Listing row set —
6.8s - ✅ Cascading report parameters against Fineract › sends the parent value to the child lookup and clears the child when it changes —
7.7s - ✅ Chart reports against Fineract › renders a chart report as a chart rather than a table —
4.8s
savings-flows-non-admin-roles.spec.ts
- ✅ a savings account taken through four separated duties, every account built in the UI › an administrator builds the five roles and accounts through the forms —
51.8s - ✅ a savings account taken through four separated duties, every account built in the UI › the officer books the application and is not offered approval of it —
9.6s - ✅ a savings account taken through four separated duties, every account built in the UI › the approver, differing in one code, is offered it and approves —
5.7s - ✅ a savings account taken through four separated duties, every account built in the UI › the activator activates, and cannot take a deposit —
5.7s - ✅ a savings account taken through four separated duties, every account built in the UI › the teller, holding only the transaction codes, records a deposit end to end —
6.3s - ✅ a savings account taken through four separated duties, every account built in the UI › the cash-withdrawal control asks for the cash code, not the application one —
17.9s - ✅ a savings account taken through four separated duties, every account built in the UI › the transaction route refuses an UPDATE_SAVINGSACCOUNT holder, as the platform does —
7.3s
savings-transaction-correction.spec.ts
- ✅ Savings transaction correction › a deposit is reversed and a hold is released —
7.0s
savings-transaction-gating.spec.ts
- ✅ Savings transactions are offered only on an active account › withheld while awaiting approval, offered once active —
6.6s - ✅ Savings transactions are offered only on an active account › the platform refuses a deposit on an account awaiting approval —
202ms
share-account-servicing.spec.ts
- ✅ Share account servicing › an account is approved, activated, traded and closed —
12.6s - ✅ Share account servicing › an application can be rejected —
6.0s
share-product-accounting.spec.ts
- ✅ Share product accounting › a share product is mapped to equity and round-trips on edit —
28.2s
teller-cash-management.spec.ts
- ✅ Teller cash management › a cashier is listed, receives an allocation, and settles cash back —
28.6s - ✅ Teller cash management › settling more than the cashier holds is refused and the form stays usable —
13.3s
tenant-date-defaults-backend.spec.ts
- ✅ Date defaults come from the platform, not the browser › a client can be created while the browser is a day ahead —
7.5s
working-capital-loan-actions-backend.spec.ts
- ✅ Working Capital loan actions, against a real Fineract › charges off an active loan, and then offers only the undo —
9.1s - ✅ Working Capital loan actions, against a real Fineract › credits the borrower with a goodwill credit, and the balance falls —
6.9s - ✅ Working Capital loan actions, against a real Fineract › writes the loan off, which closes it and opens the recovery path —
8.9s
working-capital-product-accounting-backend.spec.ts
- ✅ Working Capital product accounting, on the platform › configures the accrual rule and its twelve accounts, and the platform accepts it —
17.5s - ✅ Working Capital product accounting, on the platform › prefills a configured product and re-saves it without blanking anything —
6.0s
working-capital-rbac-backend.spec.ts
- ✅ Working Capital command permissions, on the platform › each command is authorised by the code the UI declares for it —
5.7s - ✅ Working Capital command permissions, on the platform › UPDATE_WORKINGCAPITALLOAN authorises none of them —
2.3s
working-capital-servicing-backend.spec.ts
- ✅ transaction corrections › undoes a repayment, and the platform marks it reversed —
6.7s(retried 2×) - ✅ transaction corrections › offers no correction on the disbursement, which the platform refuses by type —
5.8s(retried 2×) - ✅ transaction corrections › adjusts a repayment, which reverses it and books the new amount —
6.0s(retried 2×) - ❌ charge adjustment › adjusts a charge, and the outstanding amount follows —
275ms(retried 2×) - ⏭️ custom datatables › adds, edits and deletes a row of a multi-row table on the loan —
0ms(retried 2×) - ⏭️ custom datatables › creates a loan that a create-time check would otherwise refuse —
0ms(retried 2×)
Slowest 10 — what the shard counts should be tuned against
| Test | Spec | Time |
|---|---|---|
| Full feature demo recording › walk through loan schedule type, lifecycle, custom fields, collateral, and disbursement | full-demo.spec.ts |
59.5s |
| a savings account taken through four separated duties, every account built in the UI › an administrator builds the five roles and accounts through the forms | savings-flows-non-admin-roles.spec.ts |
51.8s |
| a loan taken through four separated duties, every account built in the UI › an administrator builds the four roles and accounts through the forms | loan-flows-non-admin-roles.spec.ts |
39.4s |
| Loan product accounting › a cash-accounting product is configured, round-trips on edit, and posts to the ledger | loan-product-accounting.spec.ts |
33.3s |
| Loan lifecycle: creation, approval, disbursement › create, approve, and disburse a Cumulative loan | loan-lifecycle.spec.ts |
32.1s |
| Loan lifecycle: creation, approval, disbursement › create, approve, and disburse a Progressive loan | loan-lifecycle.spec.ts |
32.0s |
| Loan lifecycle: creation, approval, disbursement › an approved loan can be returned to pending approval | loan-lifecycle.spec.ts |
29.8s |
| Teller cash management › a cashier is listed, receives an allocation, and settles cash back | teller-cash-management.spec.ts |
28.6s |
| Share product accounting › a share product is mapped to equity and round-trips on edit | share-product-accounting.spec.ts |
28.2s |
| Loan lifecycle: creation, approval, disbursement › the delinquency tab reads a real loan, and the empty data tabs stay hidden | loan-lifecycle.spec.ts |
28.0s |
📼 Download the HTML report, videos and traces — see the playwright-report-backend artifact.
Generated by run 39435169256 from c9e9244. The run executed a fork branch, so treat its contents as unverified.
Contributor
🔄 What this change talks toFrom the 1 application TypeScript file(s) changed in this pull request. sequenceDiagram
autonumber
participant MainLayoutComponent as MainLayoutComponent (Component)
participant GuidanceService as GuidanceService (Injected)
participant Router as Router (Injected)
MainLayoutComponent->>GuidanceService: startTour()
MainLayoutComponent->>Router: navigate()
Generated by run 39435169175 from |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
Closes #746
Two parts, one commit each, both from the fix suggested in the issue.
1. A skip link. "Skip to main content" is now the first stop in the tab order on every
authenticated page. It stays off screen until it takes focus. Enter moves focus to
<main>, whichnow has
id="main-content"andtabindex="-1". From there the next Tab is the first control in thepage content, so it takes 2 key presses instead of 105.
The link handles its own click rather than leaving it to the browser. With
<base href="/">, a bare#main-contentresolves to/#main-content, so a plain anchor would leave the page instead ofmoving within it.
2. Focus moves to
<main>when the page changes. Without this, after picking a sidebar linkfocus stays on that link (or drops to the top of the document if the control was destroyed), and the
next Tab goes back through the navigation. Three cases are left alone on purpose:
not taken from the control the user just pressed
<main>, such asNotFoundComponentfocusing its own headingmaingets no focus ring when it takes focus as a target, because it is not a control.The string is in
en,fr,hiandko.Testing
main-layout.component.test.ts(first focusable element, click handling,path change, query-only change, focus already in
main).e2e/skip-link.spec.tsin the mocked project. First Tab on a fresh load lands on theskip link and it is in the viewport, Enter puts focus on
mainand the URL does not change, andAlt+C to Create Client leaves focus inside
main.mainand pass with the change.mainan id changes how axe names the existingscrollable-region-focusablefinding inaccessibility.spec.ts's shell baseline, so that key moves frommainto#main-content. Samefinding, new selector. (A keyboard user can now reach
mainthrough the skip link and scroll itwith the arrow keys, but axe only counts elements in the tab order, so it still reports it.)
npm run buildclean.keyboard-shortcuts,accessibility,breadcrumb,global-search-navigationandguidance-tourspecs,npm run lint,format:check,check:a11y-names,typecheck:e2e.npm run i18n:checkfails onmainalready (fr.json defines ON_HOLD_TRANSACTIONS.REASON, which en.json does not, from the French catalogue in #819). I left that alone since it is not part of thischange.