Repository navigation
fix(deposits): make the deposit product, account form, view and closure work end to end - #804
Merged
Aman-Mittal merged 9 commits intoOct 18, 2026
Conversation
…it figures
The Overview of every fixed and recurring deposit account showed "Balance $" with no amount,
and none of the figures that define a term deposit. The data was in the response the whole time,
one level down: a deposit account carries no top-level `accountBalance` at all. Measured against
a running Fineract, an active fixed deposit holding 5,000 answers `accountBalance: undefined` and
`summary: { accountBalance: 5000 }`, so the view read the top level, got nothing, and rendered a
currency symbol followed by a blank.
The top level is read as a fallback rather than dropped, because the savings screens share this
component and a payload that does carry it should not be ignored. When neither is present the
accessor answers `null` rather than 0: an unknown balance and a zero balance are different
facts, and reporting the second for the first is how a wrong figure gets quoted to a customer.
Adds deposit amount, term, maturity amount, maturity date, the funding account and whether
interest is paid to savings — each rendered only when the payload carries it, so the savings
accounts that reach this view through the same component show no row of blanks. The term names
its unit: 12 days, 12 months and 12 years are not interchangeable, and the payload sends the
unit as an enum object beside the count.
Removes `getBalance()`, which read the same absent field and returned 0. The issue flagged it as
a risk to the closure dialogs and could not confirm it; it has no callers, so the answer is that
it was dead rather than dangerous — and it is gone before someone wires it up.
The fixture in the new tests is the real payload, with no top-level `accountBalance`. One that
invented the field would have passed against the broken code, which is what the issue asks to
rule out.
Closes apache#764
Creating a fixed or recurring deposit product sent an interest rate chart the user never saw: a single slab at **5% for 1–60 months**, dated from the browser's today. The form showed no interest fields at all, so an administrator configuring a 7% two-year product got a 5% five-year one, and every account opened under it inherited that rate. `defaultChart()` even documented itself as a placeholder. The fix is not a better default. A term deposit product *is* its rate chart, so the rate has to come from the user: the chart is now an explicit section with one empty slab, and the form cannot be submitted until a rate and a starting period are given. Tiered products work — a slab per term band, each sent — and an edit shows the product's own rates and can change them, carrying the chart and slab ids back so the platform treats the result as a change rather than a new chart, which it answers with a 500. An emptied rate field reads as `undefined`, not 0, and a slab without a rate is dropped rather than sent as zero. Zero is a rate an institution might actually mean, so it cannot double as "not filled in"; the submit stays disabled instead. Compounding, posting, calculation and days-in-year were hard-coded and invisible too, so a product's interest behaviour was whatever the form happened to default to. All four are now selects driven by the product template, along with the chart's period types. Required fields are marked and a disabled Save says why, following the convention `office-form.component.ts` already uses — the `.required-marker` span and the `COMMON.COMPLETE_REQUIRED_FIELDS` note with `aria-live="polite"`. The editor is shared rather than inlined in each form. Both product forms are files where Ionic markup would have been allowed, but duplicating a rate editor across them was the worse trade, so it is a new component built on native controls — the third option `_common.scss` documents under `.form-field` for exactly this case, since ADR 0005 puts Ionic out of bounds for new files and `src/app/ui` has no input primitive yet (apache#287, apache#684). It adds no suppression. Validity is reported rather than registered: `NgModel` resolves its `ControlContainer` through the host injector, so controls inside the editor's own template do not join the parent `ngForm` even though they sit inside the form element. The editor exposes `complete()` and each parent disables its own submit on it, which keeps one source of truth per form. Recurring deposit products carried the identical bug through the same `defaultChart()`, and are fixed with it. Closes apache#765
…turity instructions Choosing a product on Create Fixed Deposit Account filled nothing in: amount, term and the required interest rate all stayed empty, Save stayed disabled, and nothing said why. The cause was that the prefill read four fields the platform does not send. Measured against a running Fineract, `GET /fixeddepositaccounts/template?clientId&productId` carries no `depositAmount`, no `depositPeriod` and no `depositPeriodFrequency`, and sends `nominalAnnualInterestRate` as **0** — so `0 || undefined` disposed of the one field that was there. What the template does carry is `minDepositTerm`, `minDepositTermType` and `accountChart`. The rate now comes from the chart's slab for the chosen term rather than being retyped, which is the point of the issue: a hand-entered rate can disagree with the product, the defect apache#761 reports for savings. Changing the term re-reads it, so a tiered product cannot be saved at another band's rate. The deposit amount comes from the product, which is the only place it is — `productOptions` on the template lists `{id, name, withHoldTax}` and nothing else — so this makes two requests and says why. That also explains the second half of the issue, which looked like an Ionic defect. The Frequency select "showed a preselected value while its control was invalid" because the prefill assigned `undefined` to the model property the select is bound to: the control emptied and failed its `required` validator while the select went on displaying Months. It only appeared after choosing a product, which is why the reproduction meets it at step 4. Prefill now skips undefined values, so nothing the user can see is silently blanked, and the frequency survives a template that states no term unit at all. The prefill goes through `signal.update` rather than assigning into `account()`'s properties. Mutating the object changes the value without telling anything that reads the signal, so even a field that did resolve could fail to reach the view. Adds the maturity instruction, its transfer target and the funding account (apache#783), offered once a product is chosen because the options come from its template. `transferToSavingsId` is required exactly when the instruction is "transfer to savings", which is what the platform demands, and omitted otherwise rather than describing a transfer that will not happen. One correction to apache#783 worth stating, because getting it wrong would move a customer's money: `linkAccountId` is not the maturity payout account, it is the **funding** account. Activation debits it by the deposit amount — a savings account holding 20,000 went to 15,000 when a 5,000 deposit linked to it was activated, and an unfunded linked account makes activation fail with 403 "Insufficient account balance." It is labelled "Fund From Savings Account" with a warning that says what activation will do. Required fields are marked and a disabled Save says why. Closes apache#766 Part of apache#783
…a deposit account
A term deposit could only be closed one way: withdraw the proceeds. The dialog read the
platform's four closure options and threw three away, because it could not collect what they
need. So an institution could not offer auto-renewal, could not pay a maturing deposit into the
customer's savings account, and could not charge a deposit account at all.
Which options are actually available depends on the command, and the template does not say so —
it returns all four for both. Measured against a running Fineract:
close (matured) 100 withdraw, 200 transfer, 300 reinvest both, 400 reinvest principal
prematureClose 100 and 200 accepted; 300 and 400 refused, `reinvest.not.allowed`
So the filtering is the UI's job. A maturity closure offers all four; a premature one offers the
two the platform will accept, rather than passing the template through and producing a dead-end
choice for half of them.
Transfer to savings collects its target, which the platform makes mandatory, defaulting to the
account the deposit already pays into and refusing to confirm without one — refused here instead
of sent and reported as a failure. The target is sent only with a transfer: attaching one to a
withdrawal would describe a movement that is not going to happen.
Re-investing says what it will do before it is confirmed. Measured: it closes this deposit and
opens a new one for the maturity amount, left pending approval. Without that note the user has
to discover the second account.
Adds an Add Charge action on the deposit charges tab, gated on `CREATE_SAVINGSACCOUNTCHARGE`.
The charges offered are the ones the account template allows, because that list is a property of
the deposit product — offering any savings charge would make a dialog whose submit can only be
refused — and the button is disabled when the product allows none. A deposit account is a
savings-type account, so the charge goes to `POST /savingsaccounts/{id}/charges`, which is the
only endpoint the platform exposes for it.
The confirm dialog's fields gained a `select` type to carry the charge picker, completing the
prompt added for the charge servicing in apache#754. `RequiresPermissionDirective` is now registered
on the deposit view: the new gate would otherwise have been an unknown attribute on a known
element, which Angular accepts silently — a gate that does nothing is worse than none.
Part of apache#783
…and fix two reads it caught Five tests, end to end, because every issue in this batch came from reading the wrong field off a real payload — and three of them had unit tests that passed against invented fixtures. So a product is created through the form and read back from the platform, an account is opened and activated, and the figures are compared against the platform's own numbers rather than against the screen. The rate test is the one that matters most: it types 7.25 into the chart editor, saves, and reads the product back. A 5 there would be the chart the form used to invent, which is apache#765's "financial terms set without consent". It also checks Save is refused while the chart has no rate, which is what that silent default hid. Two defects the run caught, neither of them visible to a unit test: **The charge options never loaded.** `loadChargeOptions` read `savingsProductId`, which is what the generated type declares and what the savings response calls it. A fixed deposit answers only `depositProductId`, so the Add Charge button was permanently disabled. The same read is in the account form's edit path, where it left the product unselected on every edit of an existing account — a pre-existing bug of exactly the kind apache#766 is about, fixed with it. **The chart editor logged NG01354 on every product form.** Its controls sit inside the parent form element but cannot register with its `NgForm`, which is the constraint the component was designed around — it reports `complete()` instead. Angular warns about it anyway, four times per render. Each control is now declared `standalone`, which is the framework's own second suggestion and says the intent in the code rather than in a comment. Two NG01354 warnings remain on those pages, from `product-accounting-section.component.ts`. They predate this batch and every product form shows them. Left alone deliberately: silencing them with `standalone` would be honest about what happens today, but the alternative fix — `viewProviders` — would make those fields block submit for the first time, and which of the two is wanted is a decision beyond these four issues. Part of apache#764, apache#765, apache#766, apache#783
Contributor
🔄 What this change talks toFrom the 12 application TypeScript file(s) changed in this pull request. sequenceDiagram
autonumber
participant FineractDepositAccountApi as FineractDepositAccountApi (Service)
participant FixedDepositAccountTransactionsService as FixedDepositAccountTransactionsService (API client)
participant Fineract as Fineract (REST API)
participant RecurringDepositAccountService as RecurringDepositAccountService (API client)
participant FixedDepositAccountService as FixedDepositAccountService (API client)
participant RecurringDepositProductService as RecurringDepositProductService (API client)
participant FixedDepositProductService as FixedDepositProductService (API client)
participant RecurringDepositAccountTransactionsServi as RecurringDepositAccountTransactionsService (API client)
participant SavingsChargesService as SavingsChargesService (API client)
participant DialogService as DialogService (Service)
participant I18N as I18N (Injected)
participant DepositAccountViewComponent as DepositAccountViewComponent (Component)
FineractDepositAccountApi->>FixedDepositAccountTransactionsService: getFixeddepositaccountsFixedDepositAccountIdTransactions()
FixedDepositAccountTransactionsService->>Fineract: getFixeddepositaccountsFixedDepositAccountIdTransactions()
Fineract-->>FixedDepositAccountTransactionsService: response
FineractDepositAccountApi->>RecurringDepositAccountService: getRecurringdepositaccountsTemplate()
RecurringDepositAccountService->>Fineract: getRecurringdepositaccountsTemplate()
Fineract-->>RecurringDepositAccountService: response
FineractDepositAccountApi->>FixedDepositAccountService: getFixeddepositaccountsTemplate()
FixedDepositAccountService->>Fineract: getFixeddepositaccountsTemplate()
Fineract-->>FixedDepositAccountService: response
FineractDepositAccountApi->>RecurringDepositProductService: getRecurringdepositproductsProductId()
RecurringDepositProductService->>Fineract: getRecurringdepositproductsProductId()
Fineract-->>RecurringDepositProductService: response
FineractDepositAccountApi->>FixedDepositProductService: getFixeddepositproductsProductId()
FixedDepositProductService->>Fineract: getFixeddepositproductsProductId()
Fineract-->>FixedDepositProductService: response
FineractDepositAccountApi->>RecurringDepositAccountService: getRecurringdepositaccountsAccountIdTemplate()
RecurringDepositAccountService->>Fineract: getRecurringdepositaccountsAccountIdTemplate()
Fineract-->>RecurringDepositAccountService: response
FineractDepositAccountApi->>FixedDepositAccountService: getFixeddepositaccountsAccountIdTemplate()
FixedDepositAccountService->>Fineract: getFixeddepositaccountsAccountIdTemplate()
Fineract-->>FixedDepositAccountService: response
FineractDepositAccountApi->>RecurringDepositAccountService: postRecurringdepositaccounts()
RecurringDepositAccountService->>Fineract: postRecurringdepositaccounts()
Fineract-->>RecurringDepositAccountService: response
FineractDepositAccountApi->>FixedDepositAccountService: postFixeddepositaccounts()
FixedDepositAccountService->>Fineract: postFixeddepositaccounts()
Fineract-->>FixedDepositAccountService: response
FineractDepositAccountApi->>RecurringDepositAccountService: putRecurringdepositaccountsAccountId()
RecurringDepositAccountService->>Fineract: putRecurringdepositaccountsAccountId()
Fineract-->>RecurringDepositAccountService: response
FineractDepositAccountApi->>FixedDepositAccountService: putFixeddepositaccountsAccountId()
FixedDepositAccountService->>Fineract: putFixeddepositaccountsAccountId()
Fineract-->>FixedDepositAccountService: response
FineractDepositAccountApi->>RecurringDepositAccountTransactionsServi: postRecurringdepositaccountsRecurringDepositAccountIdTransactionsTransactionId()
RecurringDepositAccountTransactionsServi->>Fineract: postRecurringdepositaccountsRecurringDepositAccountIdTransactionsTransactionId()
Fineract-->>RecurringDepositAccountTransactionsServi: response
FineractDepositAccountApi->>FixedDepositAccountTransactionsService: postFixeddepositaccountsFixedDepositAccountIdTransactionsTransactionId()
FixedDepositAccountTransactionsService->>Fineract: postFixeddepositaccountsFixedDepositAccountIdTransactionsTransactionId()
Fineract-->>FixedDepositAccountTransactionsService: response
FineractDepositAccountApi->>SavingsChargesService: postSavingsaccountsSavingsAccountIdCharges()
SavingsChargesService->>Fineract: postSavingsaccountsSavingsAccountIdCharges()
Fineract-->>SavingsChargesService: response
FineractDepositAccountApi->>RecurringDepositAccountService: postRecurringdepositaccountsAccountId()
RecurringDepositAccountService->>Fineract: postRecurringdepositaccountsAccountId()
Fineract-->>RecurringDepositAccountService: response
Truncated for readability: 10 further participant(s) and 12 further call(s) not shown.
Generated by run 39106375562 from |
…ire facts in it
Four defects in this module came from reading a field that is not where it looks like it should
be, and three shipped with unit tests that passed against invented fixtures. Each was a
statement about the wire made at a call site instead of once:
accountBalance absent; the balance is summary.accountBalance
savingsProductId absent; a deposit answers depositProductId
template's nominalAnnualInterestRate sent as 0; the rate is in the chart's slabs
template's depositAmount absent; it is on the product
That is what ADR 0006's boundary is for, so this adds `DEPOSIT_ACCOUNT_API` and moves the
account view, the closure dialog and the fixed deposit account form behind it. All four facts
are now stated in `mapDepositAccount` and the template mapping, with the measurements beside
them, and pinned in the adapter's own test against the real payloads. A fixture cannot invent a
rate field that the model does not have.
It also absorbs what the screens were doing by hand. The account view built four URLs itself
with `BASE_PATH` and `HttpClient`, because `GET /{type}depositaccounts/{id}` returns `charges`
and `accountChart` only with `associations=all` and the generated client has no parameter for it
— upstream documents the query in a comment and omits it from the operation. That workaround is
legitimate; having it in a feature component was not. It is now one place with the reason
written down, which is what ADR 0003 asks. The same goes for the transaction list, where a
recurring deposit has no list endpoint and a fixed one does: a fact about the platform, not
about that screen.
One behaviour change fell out of it. Opening an existing account for editing used to re-run the
product prefill, which would have replaced the account's agreed term and rate with the
product's current defaults. Loading the option lists is now separate from prefilling them, and
edit does only the former: an account's rate is the agreement with the customer.
The screens' tests change with them, and that is the visible benefit. They no longer name
generated methods or guess at payload shapes — `expect(deposits.command).toHaveBeenCalledWith('fixed', 7, 'approve', …)`
rather than a four-positional call on `postFixeddepositaccountsAccountId` — and the one test
that existed to pin a generated method name now asserts the thing the screen is actually
responsible for: asking for the right kind of deposit.
`eslint-suppressions.json` shrinks: 429 generated-API imports to 422, five files freed
entirely, 464 suppressed files to 462. The ratchet only moves this way.
What is left, named rather than hidden: `DepositAccount.raw` carries the payload for the view's
remaining untyped bindings, and the interest-rate-chart tab still reads its slabs through it
because it displays more of a slab than the model carries. The two deposit *product* forms are
not migrated either. Both are the next pass, not this one.
The funding-account select offers a "None" option, and the label referenced `COMMON.NONE` without that key existing — so it would have rendered as the raw key, which the i18n adapter does deliberately to make a missing translation diagnose itself. Caught by CI's translation check. My own run of the same script reported it and I did not see it: I piped the output through `tail -1`, which kept the trailing "catalogues consistent" line and dropped the failure above it. Closes nothing; completes apache#783's funding control.
Contributor
E2E — mocked backend🎭 E2E Tests✅ All green — 423 passed · 0 failed · 1 skipped · 1 flaky, across 40 spec files in 9m 5s.
|
| Spec | ✅ | ❌ | ⏭️ | 🔒 | Time |
|---|---|---|---|---|---|
| accessibility.spec.ts | 5 | 0 | 0 | 0 | 32.9s |
| all-functions-read-shortcut.spec.ts | 5 | 0 | 0 | 0 | 9.6s |
| branded-deployment.spec.ts | 9 | 0 | 0 | 0 | 18.2s |
| breadcrumb.spec.ts | 2 | 0 | 0 | 0 | 5.5s |
| client-date-picker-revisit.spec.ts | 1 | 0 | 0 | 0 | 6.7s |
| client-servicing-gaps.spec.ts | 14 | 0 | 0 | 0 | 1m 1s |
| client.spec.ts | 1 | 0 | 0 | 0 | 4.1s |
| collateral-currency-search.spec.ts | 5 | 0 | 0 | 0 | 18.1s |
| date-picker-revisit.spec.ts | 6 | 0 | 0 | 0 | 26.3s |
| deployment-customization.spec.ts | 19 | 0 | 0 | 0 | 38.6s |
| deposit-product-edit.spec.ts | 2 | 0 | 0 | 0 | 7.2s |
| e2e-journey.spec.ts | 81 | 0 | 0 | 0 | 2m 33s |
| feature-coverage.spec.ts | 49 | 0 | 0 | 0 | 1m 18s |
| functional-coverage.spec.ts | 42 | 0 | 0 | 0 | 1m 49s |
| global-search-nav-shortcuts.spec.ts | 4 | 0 | 0 | 0 | 9.9s |
| global-search-navigation.spec.ts | 8 | 0 | 0 | 0 | 22.2s |
| group-detail.spec.ts | 8 | 0 | 0 | 0 | 35.8s |
| guidance-tour.spec.ts | 5 | 0 | 1 | 0 | 15.3s |
| keyboard-shortcuts.spec.ts | 5 | 0 | 0 | 0 | 10.6s |
| list-load-failure.spec.ts | 5 | 0 | 0 | 0 | 19.0s |
| list-pagination.spec.ts | 13 | 0 | 0 | 0 | 55.7s |
| loan-delinquency-actions.spec.ts | 11 | 0 | 0 | 0 | 45.2s |
| loan-portfolio-summary.spec.ts | 4 | 0 | 0 | 0 | 15.5s |
| loan-product-down-payment.spec.ts | 13 | 0 | 0 | 0 | 58.2s |
| charge-refund.spec.ts | 1 | 0 | 0 | 0 | 6.8s |
| client-accounts.spec.ts | 2 | 0 | 0 | 0 | 9.9s |
| client-load-error.spec.ts | 2 | 0 | 0 | 0 | 7.8s |
| contract-termination.spec.ts | 1 | 0 | 0 | 0 | 8.0s |
| loan-schedule-type-gating.spec.ts | 6 | 0 | 0 | 0 | 21.6s |
| loan-servicing-gaps.spec.ts | 18 | 0 | 0 | 0 | 1m 10s |
| logout-reason-notice.spec.ts | 4 | 0 | 0 | 0 | 4.2s |
| oidc-login.spec.ts | 8 | 0 | 0 | 0 | 14.5s |
| rbac-feature-flag.spec.ts | 11 | 0 | 0 | 0 | 22.1s |
| rbac-route-protection.spec.ts | 18 | 0 | 0 | 0 | 1m 52s |
| report-enhancements.spec.ts | 2 | 0 | 0 | 0 | 7.7s |
| reporting.spec.ts | 2 | 0 | 0 | 0 | 4.7s |
| scheduler-jobs.spec.ts | 3 | 0 | 0 | 0 | 11.6s |
| sidebar-active-state.spec.ts | 1 | 0 | 0 | 0 | 1m 25s |
| two-factor-authentication.spec.ts | 10 | 0 | 0 | 0 | 18.9s |
| working-capital-loan-actions.spec.ts | 17 | 0 | 0 | 0 | 1m 16s |
All 424 tests — click to expand
accessibility.spec.ts
- ✅ Runtime accessibility › client list has no blocking violations —
3.9s - ✅ Runtime accessibility › client list links meet color contrast in dark mode —
4.3s - ✅ Runtime accessibility › client form has no blocking violations —
5.0s - ✅ Runtime accessibility › banner and dashboard content have no blocking violations —
15.4s - ✅ Runtime accessibility › create office dialog has no blocking violations —
4.4s
all-functions-read-shortcut.spec.ts
- ✅ ALL_FUNCTIONS_READ shortcut › grants read access to the Clients list without any explicit READ_CLIENT permission —
1.9s - ✅ ALL_FUNCTIONS_READ shortcut › does not grant the Create Client action —
2.2s - ✅ ALL_FUNCTIONS_READ shortcut › does not grant Create Client even combined with an explicit READ_CLIENT permission —
2.0s - ✅ ALL_FUNCTIONS_READ shortcut › a user with the real CREATE_CLIENT permission still sees the button —
1.7s - ✅ ALL_FUNCTIONS_READ shortcut › ALL_FUNCTIONS (full superuser) still sees the Create Client button —
1.9s
branded-deployment.spec.ts
- ✅ a fully branded deployment › wears the institution’s name and mark, not Fineract’s —
1.7s - ✅ a fully branded deployment › carries the institution’s palette into its own chrome and into Ionic —
2.1s - ✅ a fully branded deployment › drops the sections the institution does not run —
1.7s - ✅ a fully branded deployment › renames and reorders entries to the institution’s vocabulary —
1.7s - ✅ a fully branded deployment › offers the institution’s own systems beside Fineract’s screens —
1.7s - ✅ a fully branded deployment › restates the labels the institution words differently —
2.0s - ✅ a fully branded deployment › keeps a readable palette in dark mode, with a label colour to match —
2.1s - ✅ a fully branded deployment › does not leak a light colour into the dark palette —
1.9s - ✅ a fully branded deployment › reports no configuration defects for the published example —
3.4s
breadcrumb.spec.ts
- ✅ a single-crumb page shows no breadcrumb trail —
1.7s - ✅ a nested page shows a trail, and the ancestor crumb navigates back —
3.8s
client-date-picker-revisit.spec.ts
- ✅ Client form date pickers › stay usable on a second visit to the create form —
6.7s
client-servicing-gaps.spec.ts
- ✅ Client transfers › proposing a transfer sends the destination, the date and the format that parses it —
4.7s - ✅ Client transfers › a one-step transfer omits the date the platform refuses —
4.8s - ✅ Client transfers › the client’s own office is not offered as a destination —
4.0s - ✅ Client transfers › accepting a transfer sends a note and nothing else —
4.6s - ✅ Client transfers › accepting with no note sends an empty body —
4.9s - ✅ Client transfers › rejecting a transfer is offered while one is pending —
4.0s - ✅ Client transfers › withdrawing is offered from on hold, which is the only way back —
5.1s - ✅ Client transfers › answers to a transfer are not offered when none is pending —
3.5s - ✅ Client staff and default savings account › assigning a member of staff sends the staff id —
4.5s - ✅ Client staff and default savings account › unassigning echoes the current holder back, which the platform requires —
4.6s - ✅ Client staff and default savings account › unassigning is not offered when nobody is assigned —
3.4s - ✅ Client staff and default savings account › the assigned officer is shown on the header —
3.3s - ✅ Client staff and default savings account › setting the default savings account sends the account id —
5.0s - ✅ Undoing a rejection › posts the command name the platform recognises, not the menu identifier —
4.7s
client.spec.ts
- ✅ Client Management › should create a new client —
4.1s
collateral-currency-search.spec.ts
- ✅ Collateral product currency — searchable select (#626) › the field is closed with no option list until it is opened —
3.6s - ✅ Collateral product currency — searchable select (#626) › typing narrows a long, alphabetical list to the matching currency —
3.7s - ✅ Collateral product currency — searchable select (#626) › matches by currency code as well as by name —
3.8s - ✅ Collateral product currency — searchable select (#626) › shows a "no results" message rather than an empty panel —
3.2s - ✅ Collateral product currency — searchable select (#626) › Cancel closes the picker without changing the selection —
3.8s
date-picker-revisit.spec.ts
- ✅ Date pickers on revisited forms › office form keeps its pickers usable on every visit —
3.9s - ✅ Date pickers on revisited forms › staff form keeps its pickers usable on every visit —
4.3s - ✅ Date pickers on revisited forms › holiday form keeps its pickers usable on every visit —
4.8s - ✅ Date pickers on revisited forms › teller form keeps its pickers usable on every visit —
4.5s - ✅ Date pickers on revisited forms › accounting closure form keeps its pickers usable on every visit —
4.0s - ✅ Date pickers on revisited forms › floating rate form keeps its pickers usable on every visit —
4.8s
deployment-customization.spec.ts
- ✅ with no overlay mounted › boots, keeps the shipped branding, and shows the full menu —
1.6s - ✅ with no overlay mounted › does not ask for an overlay this deployment has not declared —
1.6s - ✅ with no overlay mounted › logs no federation parse error on load —
1.6s - ✅ branding › applies colour and density tokens to the document —
2.0s - ✅ branding › recolours Ionic through the same tokens —
2.0s - ✅ branding › renames the product in the header and the tab title —
3.3s - ✅ branding › serves the deployment logo and names it after the deployment —
1.6s - ✅ branding › refuses a fill that cannot carry the white text baked into the stylesheet —
1.7s - ✅ branding › accepts a light accent and derives a dark label for it —
1.9s - ✅ branding › ignores a token outside the published allow-list, and says so —
2.1s - ✅ navigation › hides an entry named by its id —
2.1s - ✅ navigation › does not hide an entry named by its labelKey —
2.0s - ✅ navigation › renames and reorders entries —
3.0s(retried 1×) - ✅ navigation › adds an external entry that opens in a new tab —
2.1s - ✅ navigation › nests an added entry under an existing group —
2.1s - ✅ navigation › gates an added entry on permissions like any built-in one —
2.1s - ✅ navigation › drops an external entry with no usable url rather than rendering a dead link —
1.9s - ✅ layering › merges over config.json instead of replacing it —
1.9s - ✅ layering › a malformed overlay leaves the application usable —
2.0s
deposit-product-edit.spec.ts
- ✅ Editing a deposit product keeps what it was not asked to change › a fixed deposit product keeps its deposit amount, accounting and rate chart on save —
3.4s - ✅ Editing a deposit product keeps what it was not asked to change › a recurring deposit product keeps its deposit amount, accounting and rate chart on save —
3.7s
e2e-journey.spec.ts
- ✅ E2E: Login Flow › should display login page with all required fields —
1.3s - ✅ E2E: Login Flow › should have Sign In button disabled when fields are empty —
2.1s - ✅ E2E: Login Flow › should enable Sign In when credentials are entered —
1.4s - ✅ E2E: Login Flow › should redirect to dashboard after successful login —
1.9s - ✅ E2E: Login Flow › should display language selector on login page —
1.3s - ✅ E2E: Login Flow › should display API endpoint selector with value —
1.3s - ✅ E2E: Dashboard › should display dashboard summary cards —
1.9s - ✅ E2E: Dashboard › should display system health as Online —
2.0s - ✅ E2E: Dashboard › should display pending approvals section —
2.0s - ✅ E2E: Dashboard › should display loan and savings status distribution charts —
2.0s - ✅ E2E: Dashboard › should display system operational status —
2.0s - ✅ E2E: Dashboard › should have header with business date, render time, and logout —
1.7s - ✅ E2E: Dashboard › should have sidebar toggle button —
2.0s - ✅ E2E: Dashboard › should have global search bar in header —
2.0s - ✅ E2E: Dashboard › should have Guide button in header —
1.7s - ✅ E2E: Dashboard › should have dark mode toggle button —
1.7s - ✅ E2E: Sidebar Navigation › should have all main navigation links —
2.0s - ✅ E2E: Sidebar Navigation › should have Products section with sub-links —
2.1s - ✅ E2E: Sidebar Navigation › should have Transfers section with sub-links —
2.0s - ✅ E2E: Sidebar Navigation › should have Accounting section with sub-links —
2.2s - ✅ E2E: Sidebar Navigation › should have Security section —
2.2s - ✅ E2E: Sidebar Navigation › should have Settings section —
2.0s - ✅ E2E: Sidebar Navigation › should have Organization section —
2.1s - ✅ E2E: Sidebar Navigation › should have System section —
2.1s - ✅ E2E: Sidebar Navigation › should navigate to all major pages via sidebar —
4.5s - ✅ E2E: Offices › should display offices list with table —
2.4s - ✅ E2E: Offices › should have Create Office button —
2.1s - ✅ E2E: Offices › should navigate to office create form —
2.3s - ✅ E2E: Offices › should validate office create form - save disabled when empty —
2.2s - ✅ E2E: Offices › should fill office create form and enable save —
2.9s - ✅ E2E: Offices › should cancel office creation and return to list —
2.7s - ✅ E2E: Offices › should have search input on offices page —
2.4s - ✅ E2E: Offices › should show edit button for each office —
2.4s - ✅ E2E: Offices › should have pagination controls —
2.0s - ✅ E2E: Clients › should display clients list page —
2.3s - ✅ E2E: Clients › should display client data in table —
2.1s - ✅ E2E: Clients › should show ACTIVE status badge —
2.3s - ✅ E2E: Clients › should have Create Client button —
1.7s - ✅ E2E: Clients › should show empty state when no clients exist —
1.5s - ✅ E2E: Clients › should have search input and status filter —
1.5s - ✅ E2E: Clients › should have pagination controls —
1.5s - ✅ E2E: Client Creation › should navigate to client create form —
1.7s - ✅ E2E: Client Creation › should display all required client form fields, across the wizard steps —
2.5s - ✅ E2E: Client Creation › should display optional client form fields, across the wizard steps —
2.3s - ✅ E2E: Client Creation › should have Next disabled until the current step is valid —
2.2s - ✅ E2E: Client Creation › should populate office dropdown from API —
1.9s - ✅ E2E: Client Creation › should fill client form and enable save on the last step —
2.9s - ✅ E2E: Client Creation › should submit client and redirect to clients list —
3.2s - ✅ E2E: Client Creation › should cancel client creation and return to clients list —
1.9s - ✅ E2E: Client Creation › should have add office quick-action button —
1.7s - ✅ E2E: Client Creation › should have help icons for form fields —
1.5s - ✅ E2E: Client Creation › should have calendar buttons for date fields —
2.2s - ✅ E2E: Client Creation › should have pre-filled dates in Submitted On and Activation Date —
2.1s - ✅ E2E: Client Creation › should have Active checkbox checked by default —
1.6s - ✅ E2E: Client Creation › should handle Entity legal form showing fullname field —
3.0s - ✅ E2E: Loan Products Page › should display loan products list page —
1.5s - ✅ E2E: Loan Products Page › should have Create Loan Product button —
1.4s - ✅ E2E: Loan Products Page › should display table with correct headers —
1.5s - ✅ E2E: Loan Products Page › should show empty state when no products exist —
1.4s - ✅ E2E: Loan Products Page › should have search input —
1.5s - ✅ E2E: Loan Products Page › should navigate to loan product create form —
2.3s - ✅ E2E: Savings Products Page › should display savings products list page —
1.6s - ✅ E2E: Other Products Pages › Fixed Deposit Products page loads —
1.5s - ✅ E2E: Other Products Pages › Recurring Deposit Products page loads —
1.5s - ✅ E2E: Other Products Pages › Share Products page loads —
1.4s - ✅ E2E: Other Products Pages › Tax Components page loads —
1.5s - ✅ E2E: Other Products Pages › Tax Groups page loads —
1.6s - ✅ E2E: Other Products Pages › Floating Rates page loads —
1.5s - ✅ E2E: Loans Portfolio › should display loans portfolio page —
1.5s - ✅ E2E: Loans Portfolio › should have Create Loan Account button —
1.5s - ✅ E2E: Loans Portfolio › should display table with correct headers —
1.4s - ✅ E2E: Loans Portfolio › should show empty state when no loans exist —
1.4s - ✅ E2E: Loans Portfolio › should have search input —
1.6s - ✅ E2E: Loans Portfolio › should have pagination controls —
1.5s - ✅ E2E: Header & Global Elements › should display Fineract logo and title in header —
1.2s - ✅ E2E: Header & Global Elements › should display logged-in username —
1.3s - ✅ E2E: Header & Global Elements › should display office name for user —
1.3s - ✅ E2E: Header & Global Elements › should have Logout button —
1.2s - ✅ E2E: Header & Global Elements › should have language selector in header —
1.4s - ✅ E2E: Header & Global Elements › should display render time —
1.3s - ✅ E2E: Header & Global Elements › should display business date —
1.4s
feature-coverage.spec.ts
- ✅ Navigation & Sidebar › all main navigation links are visible in sidebar —
1.6s - ✅ Navigation & Sidebar › sidebar navigation routes to correct pages —
2.3s - ✅ Navigation & Sidebar › navigating to /accounting redirects to /accounting/chart-of-accounts —
2.3s - ✅ Navigation & Sidebar › navigating to /organization redirects to /organization/offices —
2.2s - ✅ Navigation & Sidebar › navigating to /system redirects to /system/data-tables —
2.4s - ✅ Navigation & Sidebar › an unknown route keeps its URL and offers recovery actions —
2.6s - ✅ Navigation & Sidebar › header shows logged-in user info —
1.3s - ✅ Navigation & Sidebar › help tour button is visible and interactive —
1.3s - ✅ Navigation & Sidebar › logout button is visible —
1.7s - ✅ Navigation & Sidebar › language selector is present —
1.4s - ✅ Dashboard › dashboard shows key metrics cards —
1.7s - ✅ Dashboard › dashboard shows pending approvals section —
1.4s - ✅ Dashboard › dashboard shows loan and savings status distribution —
1.2s - ✅ Dashboard › dashboard shows system operational status —
1.2s - ✅ Groups › groups page renders with title —
1.5s - ✅ Groups › groups page has create button —
1.5s - ✅ Centers › centers page renders with title —
1.6s - ✅ Centers › centers page has create button —
1.4s - ✅ Organization › offices page loads with list —
1.5s - ✅ Organization › staff page loads —
1.4s - ✅ Organization › funds page loads —
1.4s - ✅ Organization › payment types page loads —
1.6s - ✅ Accounting › chart of accounts loads —
1.5s - ✅ Accounting › journal entries page loads —
1.6s - ✅ Accounting › accounting closures loads —
1.5s - ✅ Accounting › accounting rules loads —
1.5s - ✅ Accounting › financial activity mappings loads —
1.4s - ✅ Accounting › charges page loads —
1.6s - ✅ Security › users page loads —
1.4s - ✅ Security › roles page loads —
1.5s - ✅ Security › audit logs page loads —
1.6s - ✅ Security › leftover audit trails path lands on audits, not the dashboard —
2.6s - ✅ Products - Loan & Savings › loan products page loads —
1.5s - ✅ Products - Loan & Savings › savings products page loads —
1.7s - ✅ Products - Loan & Savings › tax components page loads —
1.6s - ✅ Products - Loan & Savings › tax groups page loads —
1.5s - ✅ Products - Loan & Savings › floating rates page loads —
1.5s - ✅ Products - Loan & Savings › savings accounts page loads —
1.6s - ✅ Settings › global configurations page loads —
1.4s - ✅ Settings › holidays page loads —
1.5s - ✅ Settings › working days page loads —
1.4s - ✅ System › data tables page loads —
1.5s - ✅ System › bulk import page loads —
1.5s - ✅ System › delinquency page loads —
1.6s - ✅ Tellers › tellers page loads with create button —
1.4s - ✅ Transfers › account transfer page loads —
1.6s - ✅ Transfers › standing instructions page loads —
1.6s - ✅ Transfers › SI history page loads —
1.5s - ✅ Embedded Fintech › asset owners page loads —
1.4s
functional-coverage.spec.ts
- ✅ Client CRUD Workflow › should complete full client creation flow — Person —
3.3s - ✅ Client CRUD Workflow › should complete full client creation flow — Entity —
3.0s - ✅ Client CRUD Workflow › should cancel client creation and return to list —
1.8s - ✅ Client CRUD Workflow › should disable office and legal form in edit mode —
2.4s - ✅ Client View & Status Transitions › should display client view with correct details —
2.4s - ✅ Client View & Status Transitions › should show actions menu for pending client (status 100) —
2.4s - ✅ Client View & Status Transitions › should show actions menu for active client (status 300) —
2.4s - ✅ Client View & Status Transitions › should show actions menu for closed client (status 600) —
2.8s - ✅ Client View & Status Transitions › should show New Account menu for active client —
2.4s - ✅ Client View & Status Transitions › should navigate from client view to client list via breadcrumb —
2.4s - ✅ Client View & Status Transitions › should navigate back from client view —
3.1s - ✅ Client View Tabs › should display all expected tabs on client view —
2.4s - ✅ Client View Tabs › should switch between client view tabs —
2.5s - ✅ Search & Filter Interactions › should have search input on clients page and accept input —
2.1s - ✅ Search & Filter Interactions › should have office filter on groups page —
2.5s - ✅ Search & Filter Interactions › should have office filter on loans page —
2.7s - ✅ Search & Filter Interactions › should have search input on charges page —
2.4s - ✅ Navigation Flow Verification › should navigate full client lifecycle: list → create → back → list —
3.1s - ✅ Navigation Flow Verification › should navigate from dashboard to all top-level pages via sidebar —
4.7s - ✅ Navigation Flow Verification › should go from loan products → create → back —
2.8s - ✅ Office CRUD › should validate office create form — save disabled when empty —
2.6s - ✅ Office CRUD › should validate office create form — save enabled when filled —
2.9s - ✅ Office CRUD › should cancel office creation —
2.4s - ✅ Organization Create Flows › staff create form loads —
2.3s - ✅ Organization Create Flows › funds create form loads —
2.5s - ✅ Organization Create Flows › payment types create form loads —
2.5s - ✅ Accounting CRUD › accounting closure create form loads —
2.6s - ✅ Accounting CRUD › accounting rule create form loads —
2.5s - ✅ Accounting CRUD › financial activity mapping create form loads —
2.0s - ✅ Accounting CRUD › charge create form loads —
2.5s - ✅ Accounting CRUD › chart of accounts create form loads —
2.4s - ✅ Settings CRUD › global configurations page has editable toggle —
2.4s - ✅ Settings CRUD › holiday create form loads —
2.3s - ✅ Settings CRUD › working days page has save button —
2.4s - ✅ System CRUD › data table create form loads —
2.1s - ✅ System CRUD › delinquency page has create buttons for ranges and buckets —
2.4s - ✅ Security CRUD › role create form loads —
2.5s - ✅ Security CRUD › audit logs search form has date range —
2.7s - ✅ Security CRUD › audit logs list exports the loaded page as CSV —
2.7s - ✅ Reporting — Run Report Flow › should navigate to report and verify report parameters —
3.2s - ✅ Teller CRUD › teller create form loads —
2.6s - ✅ Create Office Dialog from Client Form › should open create office dialog from client create form —
2.8s
global-search-nav-shortcuts.spec.ts
- ✅ Global search navigation shortcuts › offers a settings page the entity search cannot return —
2.4s - ✅ Global search navigation shortcuts › navigates to the page behind a shortcut —
2.5s - ✅ Global search navigation shortcuts › keeps the results open across the mousedown that starts a click, so a slow render cannot race the dropdown closed —
2.5s - ✅ Global search navigation shortcuts › withholds a shortcut the user has no permission to reach —
2.5s
global-search-navigation.spec.ts
- ✅ Global search navigation › does not query the backend for a single character —
3.0s - ✅ Global search navigation › sends one request for a phrase typed straight through —
3.4s - ✅ Global search navigation › opens the client behind a client result —
2.7s - ✅ Global search navigation › opens the loan behind a loan result —
2.8s - ✅ Global search navigation › opens the savings account behind a savings result —
2.6s - ✅ Global search navigation › clears the query and closes the dropdown after a selection —
2.5s - ✅ Global search navigation › closes the dropdown when focus leaves without a selection —
2.3s - ✅ Global search navigation › shows nothing rather than an empty dropdown when there are no matches —
3.0s
group-detail.spec.ts
- ✅ Group detail › custom field tabs expose the app keyboard and panel contract at 1280px —
4.6s - ✅ Group detail › custom field tabs expose the app keyboard and panel contract at 390px —
4.1s - ✅ Group detail › asks for the associations, and shows every member rather than only the active ones —
4.1s - ✅ Group detail › closes a group with the reason id and a Fineract-formatted date —
6.1s - ✅ Group detail › does not offer a client who is already a member, and associates the one it does —
4.1s - ✅ Group detail › unassigns a committee role by the assignment id, not the role id —
4.1s - ✅ Group detail › offers a retry when the group cannot be loaded —
3.9s - ✅ Group detail › says so when no closure reason has been defined —
4.7s
guidance-tour.spec.ts
- ✅ the guided tour › highlights the System Status card, not the sidebar, on the dashboard tour —
2.6s - ✅ the guided tour › presents the card as a dialog named and described by its own copy —
2.1s - ✅ the guided tour › announces the step counter as a polite live region —
2.2s - ✅ the guided tour › closes on Escape and hands focus back to the Guide button —
2.6s - ✅ the guided tour › names an unmatched route after itself instead of handing it the dashboard tour —
3.7s - ⏭️ the guided tour at a phone viewport › opens from the overflow menu as a full-width bottom sheet —
2.0s
keyboard-shortcuts.spec.ts
- ✅ Alt+C jumps straight to Create Client from anywhere —
2.4s - ✅ Alt+G jumps to Create Group —
2.3s - ✅ Alt+E jumps to Create Center —
1.9s - ✅ Alt+H opens the guidance tour for the current page —
2.1s - ✅ typing in the global search box does not trigger the Create Client shortcut —
1.9s
list-load-failure.spec.ts
- ✅ entity-to-entity mapping › renders the rows the endpoint returns, rather than claiming there are none —
3.8s - ✅ entity-to-entity mapping › shows a failure state, not an empty one, when the payload cannot be read —
3.9s - ✅ entity-to-entity mapping › retries and recovers —
3.6s - ✅ report mailing jobs › reads rows out of the paged envelope the endpoint returns —
4.2s - ✅ report mailing jobs › shows a failure state when the request errors —
3.5s
list-pagination.spec.ts
- ✅ List pagination › advances through pages and back again —
4.2s - ✅ List pagination › jumps to the last page —
4.4s - ✅ List pagination › returns to the first page when a filter changes —
4.3s - ✅ List pagination › keeps search text when paging and shows the v2 account number —
4.8s - ✅ List pagination › redirects the old search page and exposes only one client navigation item —
5.3s - ✅ List pagination › keeps an account-number search broad and disables unsupported Office sorting —
4.8s - ✅ List pagination › returns to the first page when searching —
4.8s - ✅ Profile › renders the signed-in user rather than hanging on a spinner —
3.5s - ✅ Profile › changes the signed-in user password from the profile screen —
4.0s - ✅ Profile › shows an error when the profile cannot be loaded —
3.8s - ✅ List load failure › reports the failure and reloads when the user retries —
3.7s - ✅ List load failure › calendars: reports the failure and reloads when the user retries —
4.0s - ✅ List load failure › accounting rules: reports the failure and reloads when the user retries —
4.1s
loan-delinquency-actions.spec.ts
- ✅ Delinquency pause and resume on a regular loan › shows the dates as dates, and the pause periods under their real fields —
3.8s - ✅ Delinquency pause and resume on a regular loan › pauses delinquency for a period, from the business date —
4.5s - ✅ Delinquency pause and resume on a regular loan › will not take a pause that ends before, or when, it starts —
4.0s - ✅ Delinquency pause and resume on a regular loan › sends nothing when the pause dialog is cancelled —
4.7s - ✅ Delinquency pause and resume on a regular loan › shows the platform’s own reason when it refuses a pause, and stays usable —
4.3s - ✅ Delinquency pause and resume on a regular loan › resumes a pause that is in effect, dated the business date and with no end date —
4.5s - ✅ Delinquency pause and resume on a regular loan › stops offering resume once the pause has been ended —
4.5s - ✅ Delinquency pause and resume on a regular loan › does not offer resume when no pause is in effect —
4.1s - ✅ Delinquency pause and resume on a regular loan › offers neither action without the permission to create a delinquency action —
3.6s - ✅ Delinquency pause and resume on a regular loan › offers the permitted user the actions that permission opens, and no others —
3.8s - ✅ Delinquency pause and resume on a regular loan › offers neither action on a loan that is not active —
3.4s
loan-portfolio-summary.spec.ts
- ✅ Loan Portfolio Summary › searching sends entities: loans and shows the grouped results —
4.0s - ✅ Loan Portfolio Summary › Edit Parameters returns from the results view to the filter form —
3.5s - ✅ Loan Portfolio Summary › checking the outstanding-amount filter sends the between min/max values —
3.5s - ✅ Loan Portfolio Summary › switching to a single-value comparison condition sends one value —
4.6s
loan-product-down-payment.spec.ts
- ✅ Loan product down payment and tranches › down payment is offered only for a progressive product —
4.2s - ✅ Loan product down payment and tranches › the percentage and auto-repayment appear only once down payment is on —
4.5s - ✅ Loan product down payment and tranches › multi-tranche disbursement reveals its tranche count, on either engine —
3.6s - ✅ Loan product down payment and tranches › submits the down payment and tranche settings it was given —
4.8s - ✅ Loan product down payment and tranches › does not send a down payment on a cumulative product —
5.4s - ✅ Loan product down payment and tranches › income recognition is offered only for a progressive product —
4.8s - ✅ Loan product down payment and tranches › the capitalisation details appear only once it is on —
4.8s - ✅ Loan product down payment and tranches › submits the income recognition settings it was given —
4.7s - ✅ Loan product down payment and tranches › does not send income recognition on a cumulative product —
6.1s - ✅ Loan product down payment and tranches › interest recalculation reveals its mandatory settings only once it is on —
3.5s - ✅ Loan product down payment and tranches › the rest interval appears only when the frequency is not the repayment period —
4.2s - ✅ Loan product down payment and tranches › submits the interest recalculation settings it was given —
4.2s - ✅ Loan product down payment and tranches › does not send recalculation settings once it is switched back off —
3.6s
charge-refund.spec.ts
- ✅ refunds the remaining balance of a collected loan charge —
6.8s
client-accounts.spec.ts
- ✅ loan account rows show the principal returned by the accounts endpoint —
3.9s - ✅ empty account tabs offer the matching creation action —
6.0s
client-load-error.spec.ts
- ✅ shows a not-found state and returns to the list, without an error toast —
3.7s - ✅ offers a retry for a transient failure, and recovers on success —
4.1s
contract-termination.spec.ts
- ✅ terminates and undoes a progressive loan contract —
8.0s
loan-schedule-type-gating.spec.ts
- ✅ Loan schedule type gating › a cumulative loan offers neither progressive-only tab, and fetches neither —
3.8s - ✅ Loan schedule type gating › a progressive loan shows only the capabilities it actually has —
3.3s - ✅ Loan schedule type gating › fetches buy-down fees for a progressive loan that has no external id —
3.9s - ✅ Loan schedule type gating › a progressive loan with both capabilities shows both —
3.3s - ✅ Loan schedule type gating › a charged-off loan says so and offers the reversal instead —
3.4s - ✅ Loan schedule type gating › a healthy loan offers charge-off and no marker —
3.7s
loan-servicing-gaps.spec.ts
- ✅ Loan servicing gaps › edits an interest pause through PUT while preserving its existing dates —
3.7s - ✅ Loan servicing gaps › undo approval sends an empty body, without the locale the platform refuses —
4.1s - ✅ Loan servicing gaps › undo approval carries the reason when one was given —
4.3s - ✅ Loan servicing gaps › undo approval is offered only while the loan is approved —
3.1s - ✅ Loan servicing gaps › the delinquency tab shows the summary the loan carries and the tags it fetches —
3.8s - ✅ Loan servicing gaps › the data-only tabs stay hidden when the loan carries nothing for them —
3.8s - ✅ Loan servicing gaps › each data-only tab appears and renders once the loan carries its data —
3.9s - ✅ Loan servicing gaps › disburse to savings sends the date and amount, with the platform date format —
4.6s - ✅ Loan servicing gaps › disburse to savings is offered only on an approved loan —
4.2s - ✅ Loan servicing gaps › unassign loan officer sends the date, and appears only when one is assigned —
4.5s - ✅ Loan servicing gaps › unassign loan officer is hidden on a loan with no officer —
3.3s - ✅ Loan servicing gaps › undo last disbursal appears only on a multi-disbursal loan, and sends an empty body —
4.6s - ✅ Loan servicing gaps › undo last disbursal is hidden on a single-disbursal loan —
3.4s - ✅ Loan servicing gaps › close as rescheduled is offered on an active loan —
3.4s - ✅ Loan servicing gaps › revising the amounts is offered on an approved loan —
3.4s - ✅ Loan servicing gaps › revising the amounts is hidden before approval —
3.2s - ✅ Loan servicing gaps › revising the approved amount sends the new amount and locale —
4.2s - ✅ Loan servicing gaps › revising the available disbursement amount sends the new amount, including zero —
4.7s
logout-reason-notice.spec.ts
- ✅ explains an inactivity sign-out —
2.0s - ✅ explains an expired session, with different wording —
1.8s - ✅ stays silent when the user came to sign in of their own accord —
228ms - ✅ stays silent for a reason it does not recognise, rather than showing a blank notice —
254ms
oidc-login.spec.ts
- ✅ identity-provider route on the login page › a deployment that never set the flag sees the screen it always saw —
1.3s - ✅ identity-provider route on the login page › does not offer the route when the flag is false —
1.8s - ✅ identity-provider route on the login page › does not offer the route when the flag is "true" —
2.1s - ✅ identity-provider route on the login page › does not offer the route when the flag is 1 —
1.3s - ✅ identity-provider route on the login page › offers the route above the password form, which stays in place —
1.9s - ✅ identity-provider route on the login page › says plainly that it is not available yet, and goes nowhere —
1.8s - ✅ identity-provider route on the login page › username and password still sign in when the route is offered —
2.2s - ✅ identity-provider route on the login page › is not offered while a second factor is being asked for —
2.0s
rbac-feature-flag.spec.ts
- ✅ RBAC permission gating (rbacEnabled = true) › a limited user does not see permission-gated nav groups —
2.1s - ✅ RBAC permission gating (rbacEnabled = true) › a user with READ_USER sees only the Security entries that permission covers —
2.0s - ✅ RBAC permission gating (rbacEnabled = true) › the Security group fills in as the user is granted each of its permissions —
2.0s - ✅ RBAC permission gating (rbacEnabled = true) › a superuser (ALL_FUNCTIONS) sees all permission-gated groups —
1.9s - ✅ RBAC institution-feature gating (rbacEnabled = true) › universal institution shows Groups, Centers and Collection Sheet —
2.1s - ✅ RBAC institution-feature gating (rbacEnabled = true) › commercial bank (cb) hides all group-lending features —
2.0s - ✅ RBAC institution-feature gating (rbacEnabled = true) › credit union (cu) shows Groups but hides Centers and Collection Sheet —
1.7s - ✅ rbacEnabled = false › restores the pre-RBAC behaviour of showing everything —
1.8s - ✅ deployment navigation overrides › removes the entries the deployment names by id, leaving the rest alone —
2.1s - ✅ deployment navigation overrides › ignores a labelKey where an id is required —
2.2s - ✅ deployment navigation overrides › removes them even where RBAC is off —
2.1s
rbac-route-protection.spec.ts
- ✅ route authorization › a superuser reaches every sampled route and sees the full navigation —
13.8s - ✅ route authorization › a single-module user is confined to that module —
10.2s - ✅ route authorization › a read-only user gets the lists and not the forms —
12.9s - ✅ route authorization › a user with an empty permission list is refused everywhere and the app still works —
9.9s - ✅ route authorization › a session carrying no permissions field is treated as carrying none —
6.9s - ✅ route authorization › an unrecognised permission code grants nothing —
5.7s - ✅ route authorization › an unauthenticated visitor is asked to sign in, not told they are forbidden —
6.2s - ✅ route authorization › a deployment with RBAC turned off behaves as it did before the guard —
8.7s - ✅ the Access Denied page › says what happened, under a single heading —
3.9s - ✅ the Access Denied page › moves focus to the heading, since the user did not ask to come here —
4.2s - ✅ the Access Denied page › announces itself politely —
4.2s - ✅ the Access Denied page › names the permissions the screen wanted, so the user can ask for them —
3.7s - ✅ the Access Denied page › offers a way back that the user is allowed to take —
4.2s - ✅ the Access Denied page › is reachable by keyboard alone —
3.4s - ✅ permission feedback › a visible nav entry says what the user can do in that module —
2.0s - ✅ permission feedback › a nav entry carries no hint when there is nothing specific to say —
2.1s - ✅ navigation and routes agree › a hidden menu entry is also refused by URL, and a shown one is not —
6.5s - ✅ navigation and routes agree › the create button is withheld from a user whose create route would refuse them —
4.4s
report-enhancements.spec.ts
- ✅ Report Enhancements, Pagination, and Help Tour › should run report, show paginated data, and download CSV —
4.6s - ✅ Report Enhancements, Pagination, and Help Tour › should trigger guidance help tour and navigate steps —
3.1s
reporting.spec.ts
- ✅ Reporting › should display list of reports —
2.1s - ✅ Reporting › should navigate to run report page —
2.6s
scheduler-jobs.spec.ts
- ✅ Scheduler Jobs bulk run › Run Selected is disabled until a job is checked —
3.6s - ✅ Scheduler Jobs bulk run › Select All checks every job, and running confirms then triggers each one —
4.1s - ✅ Scheduler Jobs bulk run › declining the confirmation runs nothing —
3.9s
sidebar-active-state.spec.ts
- ✅ Sidebar active route matching › does not mark a parent sidebar link active on nested routes —
1m 25s
two-factor-authentication.spec.ts
- ✅ two-step verification › asks for a code and lets the user in once it is accepted —
2.0s - ✅ two-step verification › sends the token on every later request —
2.1s - ✅ two-step verification › keeps the user on the step when the code is wrong, and says why —
1.5s - ✅ two-step verification › accepts a correct code after a wrong one —
1.8s - ✅ two-step verification › offers the choice when there is more than one channel —
1.9s - ✅ two-step verification › says so when the account has no channel configured —
1.4s - ✅ two-step verification › returns to the choice when the code could not be sent —
1.5s - ✅ two-step verification › does not let a half-finished session reach the application —
3.2s - ✅ two-step verification › backing out returns to the password form —
1.7s - ✅ two-step verification › a deployment without a second factor signs in exactly as before —
1.9s
working-capital-loan-actions.spec.ts
- ✅ Working Capital loan delinquency, breach and near-breach actions, and originators › shows delinquency action history and submits a new one —
4.5s - ✅ Working Capital loan delinquency, breach and near-breach actions, and originators › shows breach action history and submits a new one —
5.7s - ✅ Working Capital loan delinquency, breach and near-breach actions, and originators › shows near-breach action history and submits a new one —
5.3s - ✅ Working Capital loan delinquency, breach and near-breach actions, and originators › attaches and detaches a loan originator —
4.1s - ✅ Working Capital loan delinquency, breach and near-breach actions, and originators › adds a new charge and waives an existing one —
4.8s - ✅ Working Capital loan delinquency, breach and near-breach actions, and originators › shows rate-change history, amortization schedule, and delinquency range tags —
3.9s - ✅ Working Capital loan delinquency, breach and near-breach actions, and originators › marks the loan as fraud, applies a discount, and changes the payment rate —
5.6s - ✅ Working Capital loan transactions, loss actions and modification › credits the borrower through a goodwill credit —
4.9s - ✅ Working Capital loan transactions, loss actions and modification › refunds a merchant payout —
4.8s - ✅ Working Capital loan transactions, loss actions and modification › refunds a credit balance only on an overpaid loan —
3.9s - ✅ Working Capital loan transactions, loss actions and modification › charges off an active loan —
4.9s - ✅ Working Capital loan transactions, loss actions and modification › swaps charge-off for its undo once the loan is charged off —
3.6s - ✅ Working Capital loan transactions, loss actions and modification › writes off an active loan —
4.6s - ✅ Working Capital loan transactions, loss actions and modification › offers recovery and undo on a written-off loan, but not a second write-off —
3.6s - ✅ Working Capital loan transactions, loss actions and modification › withholds undo write-off once a recovery has been collected —
3.8s - ✅ Working Capital loan transactions, loss actions and modification › modifies a submitted application through the edit route —
5.0s - ✅ Working Capital loan transactions, loss actions and modification › disables the actions a read-only role may not perform —
3.5s
Slowest 10 — what the shard counts should be tuned against
| Test | Spec | Time |
|---|---|---|
| Sidebar active route matching › does not mark a parent sidebar link active on nested routes | sidebar-active-state.spec.ts |
1m 25s |
| Runtime accessibility › banner and dashboard content have no blocking violations | accessibility.spec.ts |
15.4s |
| route authorization › a superuser reaches every sampled route and sees the full navigation | rbac-route-protection.spec.ts |
13.8s |
| route authorization › a read-only user gets the lists and not the forms | rbac-route-protection.spec.ts |
12.9s |
| route authorization › a single-module user is confined to that module | rbac-route-protection.spec.ts |
10.2s |
| route authorization › a user with an empty permission list is refused everywhere and the app still works | rbac-route-protection.spec.ts |
9.9s |
| route authorization › a deployment with RBAC turned off behaves as it did before the guard | rbac-route-protection.spec.ts |
8.7s |
| terminates and undoes a progressive loan contract | contract-termination.spec.ts |
8.0s |
| route authorization › a session carrying no permissions field is treated as carrying none | rbac-route-protection.spec.ts |
6.9s |
| refunds the remaining balance of a collected loan charge | charge-refund.spec.ts |
6.8s |
📼 Download the HTML report, videos and traces — see the playwright-report-mocked artifact.
Generated by run 39106375606 from 6cd0512. The run executed a fork branch, so treat its contents as unverified.
Contributor
E2E — real Fineract🎭 E2E Tests✅ All green — 168 passed · 0 failed · 0 skipped, across 48 spec files in 9m 5s. By spec file
All 168 tests — click to expand
Slowest 10 — what the shard counts should be tuned against
📼 Download the HTML report, videos and traces — see the Generated by run 39106375606 from |
…il other files
CI's Unit Tests job runs the suite three times — at UTC, at `TZ=America/New_York`, and for the
microfrontend — and it was the timezone pass that failed. Not because anything here is
timezone-dependent: both defects are unhandled async errors, and vitest attributes those to
whichever file happens to be running when they surface. At UTC they landed harmlessly; west of
Greenwich the timing shifted and one of them landed on `client-form.component.test.ts`, failing
a file with nothing to do with deposits.
That is the "flaky client-form hook timeout" I twice dismissed as full-suite load. It was not
flaky. It was this, and it was mine.
**The product form's test created the component before stubbing the read it makes.**
`setup({ get: () => '1' })` puts an id on the route, so `ngOnInit` goes straight to
`loadProductData()` — while the spy still answered `undefined`, giving
`Cannot read properties of undefined (reading 'subscribe')`. `setup` now takes the product to
answer with and stubs it before the component exists, and `setupEdit` no longer repeats by hand
what `ngOnInit` already does. The other `beforeEach` in that file stubs the same spy even
though its route carries no id, so a later route change cannot reopen the hole.
**The account form's test doubled a template the adapter cannot return.** `of({})` has no
`chartSlabs`, and `loadProductOptions` maps over it: `Cannot read properties of undefined
(reading 'map')`. The contract declares those lists non-optional and the adapter defaults every
one of them, so a double without them is lying about the boundary — which is the opposite of
what the boundary is for. There is now a named `EMPTY_TEMPLATE`: every list present and empty,
every scalar null, which is what a product offering nothing actually produces.
Fixing the second one exposed a third, smaller thing. A neighbouring case stubbed
`minDepositTermType: undefined` — the *payload's* field name, not the model's
`minDepositTermTypeId` — so it was asserting against a field that no longer exists and could
not have failed. It now states the model's field.
All three CI steps verified locally at exit 0: 2407 tests at UTC, 2407 at America/New_York with
no unhandled errors, and the microfrontend suite.
…quires one `deposit-product-configuration.spec.ts` created both deposit products by filling name, short name and description and then clicking Save. Save is now disabled until the interest rate chart states a rate, so the click waited for an actionable button until the test timed out — four minutes, twice, taking the two tests after it down with it in serial mode. That is my regression, not a flaw in the spec: apache#765 made the chart a required, visible part of creating a deposit product, because the form used to send a hidden slab at 5% for 1–60 months that nobody saw. A spec that could still save without stating a rate would be asserting the behaviour the issue removed. So both create paths now fill the chart, and the fixed deposit case asserts two things it could not before: that Save is refused while the chart has no rate, and that reopening the product brings its own rate back into the editor. The second is the other half of apache#765 — the update resends *this* product's chart with its ids rather than a newly invented one, which is what used to answer 500 and make a fixed deposit product uneditable. Also corrects something I stated wrongly in c4df18c's message. I said two NG01354 warnings remained "from product-accounting-section.component.ts". The source was right but the count was an artifact of one run: that component has a single ngModel control — the accounting-rule select — which is not declared standalone and warns once per render, so the number tracks how many product pages a run visits, not how many places are unguarded. It is one line to silence and behaviourally a no-op, since Angular refuses the registration either way; it is left alone here only because that component is shared by the loan, savings and share product forms and does not belong in a deposits change. Verified against `apache/fineract:latest` re-pulled today (acbc79431b00, 9 hours old): 11 deposit tests pass, and the two specs that pin measured platform behaviour still pass unchanged — including the one asserting that undo-waive-charge answers 500, so that control stays gated off and the platform bug stays worth reporting.
Aman-Mittal
added a commit
to Aman-Mittal/fineract-backoffice-ui
that referenced
this pull request
Oct 18, 2026
`testTimeout` was raised to 30s because the first `createComponent()` in a file compiles the component and everything it imports, which runs past Vitest's default on the larger screens. That cost is usually paid in a `beforeEach`, and `hookTimeout` was left at 10s. So `client-form.component.test.ts` and `wc-loan-product-form.component.test.ts` — wizards built from several dozen Ionic components — time out in a hook that is itself synchronous, whenever the machine is busy. It reads as a flake in whichever file the suite was running, which is how it was first mistaken for one: the same signature appeared while chasing an unrelated failure in apache#804. Verified by reproducing the cause rather than the symptom: the full suite now passes with six spinning processes alongside it, at a load average of 30, where it failed twice at idle before.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #764, #765, #766. Part of #783.
Fixed and recurring deposits could not be operated end to end: the product could not be configured honestly, the account form filled nothing in, the account view showed no figures, and a matured deposit could only be paid out in cash. Four issues, one module, and together most of epic #295.
Everything below was measured against a running
apache/fineractbefore it was written, which is how four of the issues' own assumptions turned out to be wrong.What landed
#765 — the product's rate chart is visible. Creating a deposit product used to send a chart the user never saw: one slab at 5% for 1–60 months, dated from the browser's today. An administrator configuring a 7% two-year product got a 5% five-year one, and every account opened under it inherited that rate. The chart is now an explicit, editable section; the form will not submit until a rate and a period are given; tiered products work; and an edit shows the product's own rates and carries their ids back, which is what keeps the update from a 500. Compounding, posting, calculation and days-in-year were hard-coded and invisible too — all four now come from the product template. Recurring deposit products had the identical bug and are fixed with it.
#766 — choosing a product fills the form in. The prefill read four fields the platform does not send. The template carries no
depositAmount, nodepositPeriodand nodepositPeriodFrequency, and sendsnominalAnnualInterestRateas0— so0 || undefineddisposed of the one field that was there. The rate now comes from the chart slab for the chosen term and follows the term when it changes; the amount comes from the product, the only place it is.#764 — the account view shows its figures. A deposit account carries no top-level
accountBalance; it is undersummary. Adds deposit amount, term, maturity amount, maturity date, the funding account and whether interest is paid to savings.#783 — closing and charging. A maturity closure offers all four options the platform accepts; a premature one offers the two it accepts, because the other two are refused with
reinvest.not.allowedand the template offers them anyway. Transfer to savings collects its target, re-investment says a replacement deposit will be opened pending approval, and a deposit account can now be charged.Where the issues were wrong about the platform
linkAccountIdis the funding account, not the maturity payout account. #783 describes it as "the customer's savings account" for the payout. Activation debits it: a savings account holding 20,000 went to 15,000 when a 5,000 deposit linked to it was activated, and an unfunded linked account makes activation fail with 403 "Insufficient account balance." Getting this wrong in the UI would move a customer's money, so it is labelled "Fund From Savings Account" with a warning that says what activation will do. The payout target istransferToSavingsId, which the platform makes mandatory once the instruction is "transfer to savings".Re-investment is maturity-only. Measured per command:
closeon a matured account accepts 100, 200, 300 and 400;prematureCloseaccepts 100 and 200 and refuses the two reinvest options. The close template returns all four for both, so the filtering is the UI's.The frequency bug was not an Ionic bug. #766 reports the Frequency select showing a value while its control was invalid. The cause was the prefill assigning
undefinedto the bound model property: the control emptied and failedrequiredwhile the select went on displaying Months. It only appeared after choosing a product, which is why the reproduction meets it at step 4.Two defects the e2e run caught
Charge options never loaded, because the code read
savingsProductId— what the generated type declares and what the savings response calls it. A fixed deposit answers onlydepositProductId. The same read is in the account form's edit path, where it left the product unselected on every edit.The chart editor logged NG01354 four times per render. Its controls cannot register with the parent
NgForm, which is the constraint it was designed around; each is now declaredstandalone, stating the intent in code.A note on where the editor lives
The rate editor is a new shared component built on native controls, not Ionic. Both product forms are files where Ionic markup would have been allowed, but duplicating a rate editor across them was the worse trade — and ADR 0005 puts Ionic out of bounds for new files while
src/app/uihas no input primitive yet (#287, #684)._common.scssdocuments native controls as the third option for exactly this case. It adds no suppression. This is the third batch in a row to run into the missing form primitives; #684 is worth scheduling.Left alone, deliberately
Two NG01354 warnings remain on the product forms, from
product-accounting-section.component.ts. They predate this batch and affect every product form. Silencing them withstandalonewould describe what happens today, but the alternative fix —viewProviders— would make those fields block submit for the first time, and which is wanted is a decision beyond these four issues.#783 is not fully closed: its charges acceptance criterion is met for adding, and pay/waive on a deposit charge follows the savings charge work in #754.
Verification
apache/fineract:latest, in 1.1 minutes: the five new lifecycle tests plus the three pre-existing deposit specs. The rate test types 7.25 into the editor, saves, and reads the product back from the platform; the closure test checks the proceeds actually arrived in the savings account.eslintwith no new suppressions,prettier --check,typecheck:e2e, production build.