Repository navigation
feat(#329): restructure sidebar navigation and update configurations - #736
kishanchaubey23 wants to merge 3 commits into
Conversation
E2E — mocked backend🎭 E2E Tests📼 Download the HTML report, videos and traces — see the Generated by run 38055836443 from |
E2E — real Fineract🎭 E2E Tests📼 Download the HTML report, videos and traces — see the Generated by run 38055836443 from |
🔄 What this change talks toFrom the 2 application TypeScript file(s) changed in this pull request. sequenceDiagram
autonumber
participant NavigationConfigService as NavigationConfigService (Service)
participant AuthService as AuthService (Injected)
participant InstitutionConfigService as InstitutionConfigService (Injected)
participant ConfigService as ConfigService (Injected)
participant I18N as I18N (Injected)
participant SidebarComponent as SidebarComponent (Component)
participant SidebarService as SidebarService (Injected)
participant ViewportService as ViewportService (Injected)
participant Router as Router (Injected)
NavigationConfigService->>AuthService: currentUser()
NavigationConfigService->>InstitutionConfigService: institutionType()
NavigationConfigService->>ConfigService: rbacEnabled()
NavigationConfigService->>ConfigService: developerToolsEnabled()
NavigationConfigService->>AuthService: hasPermission()
NavigationConfigService->>InstitutionConfigService: isFeatureEnabled()
NavigationConfigService->>I18N: translate()
SidebarComponent->>SidebarService: isDrawerOpen()
SidebarComponent->>SidebarService: closeDrawer()
SidebarComponent->>ViewportService: isMobile()
SidebarComponent->>SidebarService: isCollapsed()
SidebarComponent->>Router: isActive()
SidebarComponent->>NavigationConfigService: filteredNavItems()
SidebarComponent->>AuthService: currentUser()
Generated by run 38055836454 from |
|
@kishanchaubey23 Are you working on this? |
What and why
This PR restructures the sidebar navigation architecture and its corresponding configuration service. This change groups navigation components logically to improve layout hierarchy, overall UI scannability, and menu structure consistency.
Closes #329
Verification
I validated these structural changes locally via the project's native unit testing framework:
navigation-config.service.test.tsandsidebar.component.test.ts).Screenshots
Not applicable (Structural layout configuration and underlying navigation service refactor).
Checklist
src/app/api/.src/app/core/adapters/instead of direct browser globals or imperative third-party APIs.dev@fineract.apache.org first —
or it is a bug fix, refactor or test change, where that does not apply.